1160340 - Themes are marked as unverified in the add-ons manager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Dave Townsend [:mossop]]

We don't plan to sign themes so in bug 1038068 I just marked them as SIGNEDSTATE_MISSING but the UI we added shows that as unverified. The UI is doing the correct thing here, we should add a SIGNEDSTATE_EXEMPT or something as an "ok" state for install and use. It's either that or we'd have to expose the types that need signing to the frontend and I don't want to do that.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

I realised that other add-on objects in the UI that don't use signing at all (plugins, lightweight themes etc.) just have signedState == undefined. That makes sense for any add-on type that we don't care about signing for. This switches to that and also consolidates the logic for what signedState is into the verify*SignedState methods.

The periodic check will serve to update signedState on existing add-ons so even after this lands it will take a day give or take to correct existing themes unfortunately.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 8600223 [details] [diff] [review]
patch

Review of attachment 8600223 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cbe91037c39d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cbe91037c39d