Closed Bug 1160340 Opened 6 years ago Closed 6 years ago

Themes are marked as unverified in the add-ons manager

Categories

(Toolkit :: Add-ons Manager, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [fxsearch][searchhijacking])

Attachments

(1 file)

We don't plan to sign themes so in bug 1038068 I just marked them as SIGNEDSTATE_MISSING but the UI we added shows that as unverified. The UI is doing the correct thing here, we should add a SIGNEDSTATE_EXEMPT or something as an "ok" state for install and use. It's either that or we'd have to expose the types that need signing to the frontend and I don't want to do that.
Flags: qe-verify-
Flags: firefox-backlog+
Iteration: --- → 40.3 - 11 May
Points: --- → 2
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
I realised that other add-on objects in the UI that don't use signing at all (plugins, lightweight themes etc.) just have signedState == undefined. That makes sense for any add-on type that we don't care about signing for. This switches to that and also consolidates the logic for what signedState is into the verify*SignedState methods.

The periodic check will serve to update signedState on existing add-ons so even after this lands it will take a day give or take to correct existing themes unfortunately.
Attachment #8600223 - Flags: review?(dveditz)
Comment on attachment 8600223 [details] [diff] [review]
patch

Review of attachment 8600223 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz
Attachment #8600223 - Flags: review?(dveditz) → review+
https://hg.mozilla.org/mozilla-central/rev/cbe91037c39d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.