1160503 - [toolkit] In SWW, pass matching parameters to the default offline cache middle ware

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

https://github.com/arcturus/serviceworkerware/issues/17

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: wip

Right now it's a bit fuzzy, since seems Chrome doesn't support the matching options and tests stopped working in Firefox Nightly (even if i run the master branch)

Asking for feedback to check if the solution looks simple

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8600357 [details] [review]
wip

Some concerns in the test but simple enough, I think. Thank you. :)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8600357 [details] [review]
wip

Hei Salva,

could you take a second look, I added the modifications, but for any reason I'm not able to run Firefox Nightly tests on Mac OS.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8600357 [details] [review]
wip

Hei Salva,

just removed the NI, ready for r?

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8600357 [details] [review]
wip

Please, address the comments on GitHub and you're done. We are not providing any solution for Chrome, so passing options remain Firefox only.

Thanks for the work!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Landed:


https://github.com/arcturus/serviceworkerware/commit/2a30d161f0fe2c16a8442c8d8fc9727ea68dbc81

Chrome won't benefit from this yet, but will be, since the specs contains the matching options, so, hopefully, one day Chrome will honor that parameter too.