Closed Bug 1160567 Opened 9 years ago Closed 9 years ago

Assert that we do not have any Object subclasses flowing through generic GCMethods

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I should have done this when I added the JSFunction overload, but didn't want to make the bug that obvious in the checkin. We should be good now though, so let's get that assertion in place.

Filing as sec-sensitive until the try results are back, just incase.
Comment on attachment 8600381 [details] [diff] [review]
forward_security_on_object_exposure-v0.diff

Try run seems to be green.
Attachment #8600381 - Flags: review?(jcoppeard)
Comment on attachment 8600381 [details] [diff] [review]
forward_security_on_object_exposure-v0.diff

Review of attachment 8600381 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8600381 - Flags: review?(jcoppeard) → review+
Try is green -- as I thought, there are no Object subclasses other than Function we need to handle explicitly in barriers.
Group: core-security
https://hg.mozilla.org/mozilla-central/rev/10c0adba47eb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.