Closed
Bug 1160592
Opened 9 years ago
Closed 9 years ago
Bug 1157954 causes 8MiB regression in heap-unclassified in AWSY
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: seth)
References
Details
(Whiteboard: [MemShrink][awsy])
Attachments
(3 files, 1 obsolete file)
119.21 KB,
application/x-gzip
|
Details | |
113.71 KB,
application/x-gzip
|
Details | |
4.02 KB,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1157954 +++ It looks like about 8MiB of image data is no longer reported and gets lumped into heap-unclassified.
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Looks an awful lot like we're just not reporting source data anymore. It must've gotten busted in bug 1157954.
Assignee | ||
Comment 4•9 years ago
|
||
Sure enough, we mistakenly stopped reporting image source size in bug 1157954. This patch makes us report it again.
Attachment #8600549 -
Flags: review?(dholbert)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → seth
Status: NEW → ASSIGNED
Comment 5•9 years ago
|
||
Comment on attachment 8600549 [details] [diff] [review] Report image source size again in about:memory >diff --git a/image/src/imgLoader.cpp b/image/src/imgLoader.cpp >- return ReportSurfaces(aHandleReport, aData, pathPrefix, aCounter); >+ nsresult rv = ReportSurfaces(aHandleReport, aData, pathPrefix, aCounter); >+ NS_ENSURE_SUCCESS(rv, rv); [...] > static nsresult ReportValues(nsIHandleReportCallback* aHandleReport, > nsISupports* aData, > const nsACString& aPathPrefix, > const MemoryCounter& aCounter) > { > nsresult rv; > >+ rv = ReportSourceValue(aHandleReport, aData, aPathPrefix, aCounter); > NS_ENSURE_SUCCESS(rv, rv); Extreme nit: this is inconsistent in "nsresult rv" declaration style (whether it's declared ahead of time vs. declared inline with assignment). Consider making this consistent, one way or the other. r=me regardless
Attachment #8600549 -
Flags: review?(dholbert) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Thanks for the review! I made the |rv| declaration style consistent in this version of the patch.
Assignee | ||
Updated•9 years ago
|
Attachment #8600549 -
Attachment is obsolete: true
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa448752bd9
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1fa448752bd9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•