If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Reader View bar items need accessibility labels

RESOLVED FIXED

Status

()

Firefox for iOS
Reader View
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: Boris Dušek)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/ReaderModeBarView.swift
(Reporter)

Updated

2 years ago
Summary: Reader View bar items need accessibility label → Reader View bar items need accessibility labels
(Assignee)

Comment 1

2 years ago
Created attachment 8600468 [details] [review]
Pull Request
Attachment #8600468 - Flags: review?(bnicholson)
Attachment #8600468 - Flags: review?(bnicholson) → review?(sarentz)
Comment on attachment 8600468 [details] [review]
Pull Request

Just a minor not about the use of `description`. Other than that it looks good!
Attachment #8600468 - Flags: review?(sarentz) → review+
Merged
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
This bug introduced a couple of strings: "Mark as read/unread". But we still had "Mark as Read/Unread" (not the capitalization).

Is the different capitalization actually wanted and/or needed?
(Assignee)

Comment 5

2 years ago
I had no explicit intent with the capitalization. For the sake of consistency, I will change the strings from this bug to have the same capitalization as the ones already present (i.e. capitalized Read/Unread). Thanks for noting this.
(Assignee)

Updated

2 years ago
Assignee: nobody → dusek
(Assignee)

Comment 6

2 years ago
Francesco, I reported Bug 1161254 for the capitalization and took the liberty of CC'ing you there. A pull request is already available for it.
You need to log in before you can comment on or make changes to this bug.