Closed Bug 1160594 Opened 7 years ago Closed 7 years ago

Reader View bar items need accessibility labels

Categories

(Firefox for iOS :: Reader View, defect)

ARM
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronmt, Assigned: dusek)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Summary: Reader View bar items need accessibility label → Reader View bar items need accessibility labels
Attached file Pull Request
Attachment #8600468 - Flags: review?(bnicholson)
Attachment #8600468 - Flags: review?(bnicholson) → review?(sarentz)
Comment on attachment 8600468 [details] [review]
Pull Request

Just a minor not about the use of `description`. Other than that it looks good!
Attachment #8600468 - Flags: review?(sarentz) → review+
Merged
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
This bug introduced a couple of strings: "Mark as read/unread". But we still had "Mark as Read/Unread" (not the capitalization).

Is the different capitalization actually wanted and/or needed?
I had no explicit intent with the capitalization. For the sake of consistency, I will change the strings from this bug to have the same capitalization as the ones already present (i.e. capitalized Read/Unread). Thanks for noting this.
Assignee: nobody → dusek
Francesco, I reported Bug 1161254 for the capitalization and took the liberty of CC'ing you there. A pull request is already available for it.
You need to log in before you can comment on or make changes to this bug.