Closed
Bug 1160594
Opened 10 years ago
Closed 10 years ago
Reader View bar items need accessibility labels
Categories
(Firefox for iOS :: Reader View, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronmt, Assigned: dusek)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Reporter | |
Updated•10 years ago
|
Summary: Reader View bar items need accessibility label → Reader View bar items need accessibility labels
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8600468 -
Flags: review?(bnicholson)
|
||
Updated•10 years ago
|
Attachment #8600468 -
Flags: review?(bnicholson) → review?(sarentz)
|
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8600468 [details] [review]
Pull Request
Just a minor not about the use of `description`. Other than that it looks good!
|
|
||
Updated•10 years ago
|
Attachment #8600468 -
Flags: review?(sarentz) → review+
|
||
Comment 4•10 years ago
|
||
This bug introduced a couple of strings: "Mark as read/unread". But we still had "Mark as Read/Unread" (not the capitalization).
Is the different capitalization actually wanted and/or needed?
|
|
Assignee | |
Comment 5•10 years ago
|
||
I had no explicit intent with the capitalization. For the sake of consistency, I will change the strings from this bug to have the same capitalization as the ones already present (i.e. capitalized Read/Unread). Thanks for noting this.
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dusek
|
|
Assignee | |
Comment 6•10 years ago
|
||
Francesco, I reported Bug 1161254 for the capitalization and took the liberty of CC'ing you there. A pull request is already available for it.
You need to log in
before you can comment on or make changes to this bug.
Description
•