1160734 - Let about:downloads use the new in-content style-sheet

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

about:downloads should use the new in-content style-sheet to be able to remove the old inContentUI.css.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1160734.patch

If the new add-on manager richlistitem styling is wanted, I think this should be done in a followup bug.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8600597 [details] [diff] [review]
Bug1160734.patch

Review of attachment 8600597 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/downloads/contentAreaDownloadsView.css
@@ +20,5 @@
> +}
> +
> +.downloadButton > .button-box {
> +  padding-right: 3px !important;
> +  padding-left: 3px !important;

I honestly think it looks better without these paddings. I know it's different than before, but it's closer to the downloads panel, while it was not before.

@@ +21,5 @@
> +
> +.downloadButton > .button-box {
> +  padding-right: 3px !important;
> +  padding-left: 3px !important;
> +  padding-bottom: 1px;

padding: 0; looks like it's enough here

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1160734.patch

Okay, changed to padding 0px. The !important is needed to override the common.css rule. I added a comment.

Carrying over the r+

Comment 4

[Marco Bonardo [:mak]]

wait, I don't want to override the left/right padding with 0, I suggested padding: 0; just as a shortcut to padding-bottom: 0;
Why do you think we must override the side paddings?

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Marco Bonardo [::mak] from comment #4)
> Why do you think we must override the side paddings?

It was this:
(In reply to Marco Bonardo [::mak] from comment #2)
> Comment on attachment 8600597 [details] [diff] [review]
> I honestly think it looks better without these paddings. I know it's
> different than before, but it's closer to the downloads panel, while it was
> not before.

The downloads panel has 0px on all sides.

You want 10px on left/right (the in-content values) and 0px on top/bottom, correct?

Comment 6

[Marco Bonardo [:mak]]

It looks good to me on Windows with just padding-bottom: 0px; and it looks visually closer to the downloads panel. I think we can keep the in-content values for left/right padding.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Bug1160734.patch

This time with padding-bottom: 0.

Carrying over r+

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3a906efc756d

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3a906efc756d