1160745 - Fix webrtc tests building on OpenBSD (missing -lsndio)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Landry Breuil (:gaston)]

Attachment: Add -lsndio on OpenBSD

Similar to bug 1127510, currently if enabled webrtc tests fail to build on OpenBSD with missing symbols to sndio (which is needed by audio_device and cubeb)
See http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/1478/steps/build/logs/stdio for the full log.

The attached patch fixes the build for me.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8600584 [details] [diff] [review]
Add -lsndio on OpenBSD

This is a buildfile change, you officially should get a build peer (though it's trivial and for OpenBSD and for a cpp unit test)

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8600584 [details] [diff] [review]
Add -lsndio on OpenBSD

Review of attachment 8600584 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/test/common.build
@@ +140,5 @@
>  if CONFIG['OS_TARGET'] == 'Darwin':
>      OS_LIBS += CONFIG['TK_LIBS']
>  
> +if CONFIG['OS_TARGET'] == 'OpenBSD':
> +    OS_LIBS += ['sndio']

Shouldn't this only be needed in media/webrtc/signaling/test/standalone/moz.build?

Comment 3

[Landry Breuil (:gaston)]

Attachment: Add -lsndio on OpenBSD, only in standalone dir this time

That also works, i was more concerned about having it in a more "central" place so it wouldnt break if more tests were enabled/tweaked in other directories.

Can you mark it checkin-needed if you r+ it ? i wont be really available to land it (on a long trip)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8602690 [details] [diff] [review]
Add -lsndio on OpenBSD, only in standalone dir this time

Review of attachment 8602690 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/test/standalone/moz.build
@@ +57,5 @@
>  
> +if CONFIG['OS_TARGET'] == 'OpenBSD':
> +    OS_LIBS += ['sndio']
> +
> +

There's one too many carriage return.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d297060e599

Comment 6

[Landry Breuil (:gaston)]

Sorry i messed up the bug # in the patch..

Comment 7

[Landry Breuil (:gaston)]

Will have to look at the details, but my aurora build from today failed, so it might also apply there.. depending on the merges.

Comment 8

[Landry Breuil (:gaston)]

Comment on attachment 8602690 [details] [diff] [review]
Add -lsndio on OpenBSD, only in standalone dir this time

Approval Request Comment
[Feature/regressing bug #]: 	1101651 
[User impact if declined]: failure to build on OpenBSD
[Describe test coverage new/current, TreeHerder]: in m-i and m-c, NPOTB
[Risks and why]: only affects a single tier3 platform

Can a sherrif fix the bug number when commiting ?

Comment 9

[Landry Breuil (:gaston)]

Merged to m-c in https://hg.mozilla.org/mozilla-central/rev/6d297060e599  / https://bugzilla.mozilla.org/show_bug.cgi?id=911450#c24

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8602690 [details] [diff] [review]
Add -lsndio on OpenBSD, only in standalone dir this time

Approved, seems like a test-only build.

Comment 11

[Landry Breuil (:gaston)]

Dunno the status of the merges, but it might have to go to -beta - 39 is still affected

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Fx39 is on beta.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7c1e9e8d6b3

Comment 14

[Landry Breuil (:gaston)]

Comment on attachment 8602690 [details] [diff] [review]
Add -lsndio on OpenBSD, only in standalone dir this time

Approval Request Comment

[Feature/regressing bug #]: 	1101651 
[User impact if declined]: failure to build on OpenBSD
[Describe test coverage new/current, TreeHerder]: in m-i and m-c and m-a now, NPOTB
[Risks and why]: only affects a single tier3 platform

Then i guess i'll have to ask for beta approval.. sigh

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8602690 [details] [diff] [review]
Add -lsndio on OpenBSD, only in standalone dir this time

Approved for uplift to beta (39)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Bug 1101651 never landed on Fx39 (which is what mozilla-beta is).