Closed Bug 1160784 Opened 10 years ago Closed 10 years ago

Misleading declaration

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

(Keywords: clang-analyzer)

Attachments

(1 file)

remove-confusing-declaration.diff
1.65 KB, patch
smontagu
: review+
Details | Diff | Splinter Review
Found by scan-build https://people.mozilla.org/~sledru/reports/fx-scan-build/report-nsBlockFrame.cpp-ReflowBlockFrame-60-1.html#EndPath The declaration " treatWithClearance = true;" is confusing because it has no effect as the function returns a few lines after. See: https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp?from=nsBlockFrame.cpp#3155
Attachment #8600607 - Flags: review?(smontagu)
Comment on attachment 8600607 [details] [diff] [review] remove-confusing-declaration.diff Review of attachment 8600607 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense
Attachment #8600607 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/d9eec87368ce
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: