Closed
Bug 1160784
Opened 9 years ago
Closed 9 years ago
Misleading declaration
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
Details
(Keywords: clang-analyzer)
Attachments
(1 file)
1.65 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
Found by scan-build https://people.mozilla.org/~sledru/reports/fx-scan-build/report-nsBlockFrame.cpp-ReflowBlockFrame-60-1.html#EndPath The declaration " treatWithClearance = true;" is confusing because it has no effect as the function returns a few lines after. See: https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp?from=nsBlockFrame.cpp#3155
Attachment #8600607 -
Flags: review?(smontagu)
Comment 1•9 years ago
|
||
Comment on attachment 8600607 [details] [diff] [review] remove-confusing-declaration.diff Review of attachment 8600607 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense
Attachment #8600607 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9eec87368ce
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d9eec87368ce
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•