Misleading declaration

RESOLVED FIXED in Firefox 40

Status

()

--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

({clang-analyzer})

Trunk
mozilla40
clang-analyzer
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8600607 [details] [diff] [review]
remove-confusing-declaration.diff

Found by scan-build
https://people.mozilla.org/~sledru/reports/fx-scan-build/report-nsBlockFrame.cpp-ReflowBlockFrame-60-1.html#EndPath

The declaration " treatWithClearance = true;" is confusing because it has no effect as the function returns a few lines after.

See:
https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp?from=nsBlockFrame.cpp#3155
Attachment #8600607 - Flags: review?(smontagu)
Comment on attachment 8600607 [details] [diff] [review]
remove-confusing-declaration.diff

Review of attachment 8600607 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense
Attachment #8600607 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/d9eec87368ce
Assignee: nobody → sledru
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.