Closed Bug 1160789 Opened 9 years ago Closed 8 years ago

pdf.js text has lost subpixel-antialising on OS X

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
40 Branch
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: mstange, Unassigned)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 obsolete file) 

I suppose this was caused by the switch to Skia in bug 932958, and by the fact that we don't tell Skia to use subpixel-AA during text rendering.
OS: Unspecified → Mac OS X
Hardware: Unspecified → All
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → mstange
Status: NEW → ASSIGNED

        Attachment #8600953 -
        Flags: review?(jmuizelaar)

    
    

    
  
Comment on attachment 8600953 [details] [diff] [review]
patch

This makes text rendered into transparent parts of a canvas look broken.

        Attachment #8600953 -
        Flags: review?(jmuizelaar)

    
  
Depends on: 1161122

    
  
Depends on: 1161147

    
    

    
  
Comment on attachment 8600953 [details] [diff] [review]
patch

I put a patch that does this only for opaque canvases in bug 1161122. However, that doesn't fix pdf.js because the pdf.js canvas is not opaque. I filed bug 1161147 about that.

        Attachment #8600953 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4d1f80117dd4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox41:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

    
    

    
  
Oops, I put the wrong bug number on that changeset. It actually only fixes bug 1161122, and pdf.js still doesn't get subpixel AA.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  
Assignee: mstange → nobody
Status: REOPENED → NEW
Target Milestone: mozilla41 → ---
Whiteboard: [gfx-noted]

    
    

    
  
Does this bug still reproduce?

          status-firefox40:
          affected → ---
Flags: needinfo?(mstange)
Version: Trunk → 40 Branch

    
    

    
  
No, this was fixed by the combination of bug 1161122 and bug 1160789.
Status: NEW → RESOLVED
Closed: 9 years ago → 8 years ago

          status-firefox41:
          fixed → affected

          status-firefox49:
          --- → fixed
Flags: needinfo?(mstange)
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

    
    

    
  
(In reply to Markus Stange [:mstange] from comment #8)
> No, this was fixed by the combination of bug 1161122 and bug 1160789.

Thanks!

          status-firefox41:
          affected → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: