116079 - Dragging files with no extension to browser downloads the file

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Mike Pinkerton (not reading bugmail)]

Debug mozilla build from 12/19/01.

drag a text file called "foopy" to the browser from the finder.
it'll download it instead of displaying it. Drag foopy.c and all is well.

this seems to regress every other week or so.

Comment 1

[Jaime Rodriguez, Jr.]

Adding nsbeta1 keyword to all regressions so they *get some love* and attention.

Comment 2

[Blake Ross]

sorry, works fine on windows. what can I say?

Comment 3

[Mike Pinkerton (not reading bugmail)]

xpapps. if blake doesn't have a mac, get him one. these bugs aren't mine.

Comment 4

[Peter Trudelle]

->jag

Comment 5

[Peter Trudelle]

nsbeta1+ per nav triage team.

Comment 6

[jag (Peter Annema)]

-> 1.0

Comment 7

[Peter Trudelle]

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.

Comment 8

[Mike Pinkerton (not reading bugmail)]

i guess i'm going to have to fix this myself.

Comment 9

[Mike Pinkerton (not reading bugmail)]

the problem is on line 294 of nsInternetConfigService.cpp. For some reason, IC
isn't filling in the mimetype field of the ICEntry even though it should have
that info because it knows about the type/creator.

To fix another bug, pchen changed it so that we default to _binary_ if we don't
get a mimetype. That's why we try to d/l it.

over to dagley, who might be able to coax a little more out of IC than we
currently do.

Comment 10

[Steve Dagley]

Attachment: Patch to be smarter about setting mime type for 'TEXT' files

It seems the IC mappings for mime types aren't very agressive if only the type
and creator are known.	This patch implements a bandaid for the most common
case, where the file type of the file is 'TEXT'.  A more robust solution we may
consider in the futre is examining the file contents to determine the type.

Comment 11

[Brian Ryner (not reading)]

Comment on attachment 81455 [details] [diff] [review]
Patch to be smarter about setting mime type for 'TEXT' files

r=bryner

Comment 12

[David Hyatt]

sr=hyatt

Comment 13

[Steve Dagley]

Fix checked in on trunk.  Forgot to mention that this bandaid is the solution
pinkerton and I agreed was the acceptable one for now.

Comment 14

[Mike Pinkerton (not reading bugmail)]

nominating for branch

Comment 15

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 81455 [details] [diff] [review]
Patch to be smarter about setting mime type for 'TEXT' files

hyatt sr'd but didn't use the patch manager

Comment 16

[Jaime Rodriguez, Jr.]

This sounds like a good candidate to take in a couple, as we are ramping down.
adt1.0.0- [adt2 RTM]

Comment 17

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Driver's approval.  After, checking in, please add the fixed1.0 keyword.

Comment 18

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch.  Please get drivers
approval before checking in.

Comment 19

[Judson Valeski]

please checkin to the 1.0.1 branch ASAP. once there, remove the mozilla1.0.1+
keyword and add the fixed1.0.1 keyword.

Comment 20

[Steve Dagley]

Fix checked in on MOZILLA_1_0_BRANCH tag

Comment 21

[Terri Preston]

Verified fixed Mac OS X trunk build 2002060403 and Mac OS X branch build 2002060405