Clean up styling for links in the Add-ons Manager

RESOLVED FIXED in Firefox 40

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla40
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8600659 [details] [diff] [review]
patch

- No styling for .text-link needed, global/in-content/common.css takes care of it
- .button-link should only be underlined with :hover, to match common.css
- .button-link:hover color should be #178ce5, to match common.css
Attachment #8600659 - Flags: review?(dtownsend)
Flags: qe-verify-
Flags: firefox-backlog+

Comment 1

3 years ago
Comment on attachment 8600659 [details] [diff] [review]
patch

Review of attachment 8600659 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/shared/extensions/extensions.inc.css
@@ +983,5 @@
>    background-color: transparent;
>  }
>  
>  /* Needed to override normal button style from inContent.css */
>  button.button-link:not([disabled="true"]):active:hover {

The active state color should be orange as well, according to common.css
Comment on attachment 8600659 [details] [diff] [review]
patch

Review of attachment 8600659 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with Tim's change.
Attachment #8600659 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/77f5a6d23ffc
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.