Closed Bug 1160832 Opened 8 years ago Closed 8 years ago

Clean up styling for links in the Add-ons Manager

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Iteration:
40.3 - 11 May
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

patch
1.05 KB, patch
mossop
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
- No styling for .text-link needed, global/in-content/common.css takes care of it
- .button-link should only be underlined with :hover, to match common.css
- .button-link:hover color should be #178ce5, to match common.css
Attachment #8600659 - Flags: review?(dtownsend)
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8600659 [details] [diff] [review]
patch

Review of attachment 8600659 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/themes/shared/extensions/extensions.inc.css
@@ +983,5 @@
>    background-color: transparent;
>  }
>  
>  /* Needed to override normal button style from inContent.css */
>  button.button-link:not([disabled="true"]):active:hover {

The active state color should be orange as well, according to common.css
Comment on attachment 8600659 [details] [diff] [review]
patch

Review of attachment 8600659 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with Tim's change.
Attachment #8600659 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/77f5a6d23ffc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.