116088 - [FIXr]timeStamp is zero for script generated events

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Vladimir Ermakov]

If an event is generated from script the timeStamp attribute of the event is zero.

Comment 1

[Vladimir Ermakov]

Attachment: Testcase

Comment 2

[Vedran Miletic]

retargeting

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Possible patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 141289 [details] [diff] [review]
Possible patch

This implements the exact "time at which the event was created." language in
the spec.  It may be more useful to use the dispatchEvent time?  Or the
initEvent time?  Or just wontfix this, since "0" is perfectly valid per the
spec?

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 141289 [details] [diff] [review]
Possible patch

This'll only initialize an event when it's created from script, right? In other
cases, we kinda don't care about the time stamp (except in the cases where it's
already initialized).

Comment 6

[Boris Zbarsky [:bzbarsky]]

As far as I can tell, this is indeed only for cases when it's created from
script -- all other times have an nsEvent already.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.7b

Comment 8

[Dão Gottwald [:dao]]

document.createEvent("Events").timeStamp seems to give me random numbers that aren't comparable to a real event's timeStamp or Date.now().

Comment 9

[Boris Zbarsky [:bzbarsky]]

I'm pretty sure we have bugs on file on that, actually (some of the timestamps are in one unit system, while others are in another; not all of them follow the spec).