1160987 - [l10n][Settings] Arabic: The confirmation message of delete ringtone is displayed incorrectly.

Status: VERIFIED FIXED

(Mozilla Localizations :: ar / Arabic, defect)

Description

[Sue]

Attachment: wrong_confirmation_massage.png

[1.Description]:
[RTL][Flame v2.2][Nexus 5 2.2][Settings]The confirmation message of delete ringtone is displayed incorrectly with the wrong text "n\n\".
See attachment:wrong_confirmation_massage.png

[2.Testing Steps]: 
Prerequisite: Have at least one song added in ringtone list.
1. Set system language as Arabic.
2. Launch Settings -> Sound -> Manage Tones.
3. Tap the "..." button at left side of the ringtone's name.
4. Select "Delete ringtone" and observe the confirmation message. 

[3.Expected Result]: 
4. The confirmation massage should be shown correctly.

[4.Actual Result]: 
4. The message is shown incorrectly with the text "n\n\".

[5.Reproduction build]: 
Device: Flame 2.2 (affected)
Build ID               20150503162504
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.200206
Firmware Date          Sun May  3 20:02:17 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (unaffected)
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.193941
Firmware Date          Sun May  3 19:39:52 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (affected)
Build ID               20150503002500
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150503.040229
Firmware Date          Sun May  3 04:02:46 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (unaffected)
Build ID               20150503160200
Gaia Revision          e18cce173840d6ff07fb6f1f0e0ffb58b99aab3e
Gaia Date              2015-05-02 04:27:01
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/dc5f85980a82
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150503.193953
Firmware Date          Sun May  3 19:40:11 EDT 2015
Bootloader             HHZ12f

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Changing components as this is an l10n bug that should be handled within the string in Arabic

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

Ahmed is inspecting this now.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Ahmed changed the string in Pootle. marking as resolved fixed.

Comment 4

[Sue]

Attachment: verify_fail.png

Hi Josh,
This problem has been verified as fail on latest build of Flame v2.2 and Nexus 5 2.2 by the STRs in comment 0. 
Result: The wrong text "n\n\" is shown as "AA" now. 
Could you please help with it? Thanks!
See attachment:verify_fail.png
Rate: 3/3

Device: Flame 2.2 (fail)
Build ID               20150505162504
Gaia Revision          772a9491909abd02dc67278dd453746e2dd358a8
Gaia Date              2015-05-05 02:02:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3af6a0a79227
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150505.201112
Firmware Date          Tue May  5 20:11:25 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (fail)
Build ID               20150505162504
Gaia Revision          772a9491909abd02dc67278dd453746e2dd358a8
Gaia Date              2015-05-05 02:02:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3af6a0a79227
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150505.195850
Firmware Date          Tue May  5 19:59:08 EDT 2015
Bootloader             HHZ12f

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

CC'ing Dwayne since this seems to need a workaround within Pootle to get right. 
Dwayne: can you please look into this? Ahmed mentions he can't fix this within the string because Pootle doesn't allow that. Thanks

Comment 6

[Delphine Lebédel [:delphine - Use needinfo]]

Nevermind, just talked with Pike on irc. 
Apparently, that's a bug in the source i.e., we have the wrong string in our source code:
apps/ringtones/ringtones.properties:delete-desc-default-ringtone = "{{tone}}" هي النغمة الحالية.\\u0000A\\u0000Aهل أنت متأكد أنك تريد حذفها؟

Comment 7

[Ahmed Nefzaoui [:Nefzaoui]]

I submitted into pootle the string again, this time with two empty lines instead of any other form of new-line characters, let's see how this looks after it syncs with mercurial!

Comment 8

[Delphine Lebédel [:delphine - Use needinfo]]

Update: comment 7 didn't work, so flagging Dwayne again so he can possibly help fix this within pootle.

Comment 9

[Dwayne Bailey]

To keep me sane.  This is the string everyone is talking about http://mozilla.locamotion.org/ar/firefoxos/translate/#search=delete-desc-default-ringtone&sfields=source,target,locations&soptions=exact

I really do want to cry, this should be fixed in Gaia not in workarounds that confuse localisers.

Right so \000a is \n so Pootle is simply doing the right thing. \n is valid in .properties.  So some programmer not wanting to actually fix this properly or work around it in their code has created countless amounts of QA, lots of frustrated localiser time and work arounds in Pootle.  Well done, I'm sure your time was super super valuable! </rant>

Fixed now.  We sed \n into \u000a (a workaround as I really don't want to clutter Pootle code working around something that really should have been fixed correctly in Gaia).

Comment 10

[Alissa（leave from Mozilla）]

Attachment: Verify2_pass.png

This issue has been verified as pass on flame2.2 and nexus5 2.2.
Reproduce rate:0/5

Device: Flame 2.2 user
Build ID               20150510002505
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150510.043421
Firmware Date          Sun May 10 04:34:32 EDT 2015
Bootloader             L1TC000118D0
Device: Nexus5 2.2
Build ID               20150510002505
Gaia Revision          528ef60e7cda09ad43478065f5d33bda398fbeb7
Gaia Date              2015-05-08 23:40:58
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8d04cc085cf5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150510.043050
Firmware Date          Sun May 10 04:31:07 EDT 2015
Bootloader             HHZ12f