Closed
Bug 1161021
Opened 9 years ago
Closed 9 years ago
fix unbalanced start/finish calls in test_transitions_events.html
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(3 files)
4.02 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
2.10 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.76 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
In bug 1156451 comment #57 I wrote: > One thing I noticed while auditing -- the patch in bug 1141607 should have > added a started_test() call -- as, probably, should some other changes to > the test in the past. I think we're two short for the listener on #one, and > also two short for the listener on the root. But we're two over for #seven > since that listener doesn't call finished_test (and also doesn't check for > duplicate events on ::after). > > It might be worth seeing if adding the necessary calls makes failures that > are currently intermittent more reliable.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8600890 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•9 years ago
|
||
This should fix the main failure mode in bug 1156451, which is results from the transition on #four (the last transition that completes) happening after SimpleTest.finish().
Attachment #8600891 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8600892 -
Flags: review?(bzbarsky)
Comment 4•9 years ago
|
||
Comment on attachment 8600890 [details] [diff] [review] patch 1 - Add comments for existing started_test() calls r=me
Attachment #8600890 -
Flags: review?(bzbarsky) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8600891 [details] [diff] [review] patch 2 - Fix unbalanced start_test()/finished_test() calls r=me
Attachment #8600891 -
Flags: review?(bzbarsky) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8600892 [details] [diff] [review] patch 3 - Check that we don't get duplicate events for #seven::after r=me Thank you for doing this!
Attachment #8600892 -
Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/262cebc0d8a0 https://hg.mozilla.org/integration/mozilla-inbound/rev/cf53ca4ae29a https://hg.mozilla.org/integration/mozilla-inbound/rev/662519331aa2
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/262cebc0d8a0 https://hg.mozilla.org/mozilla-central/rev/cf53ca4ae29a https://hg.mozilla.org/mozilla-central/rev/662519331aa2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•