fix unbalanced start/finish calls in test_transitions_events.html

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(3 attachments)

In bug 1156451 comment #57 I wrote:
> One thing I noticed while auditing -- the patch in bug 1141607 should have
> added a started_test() call -- as, probably, should some other changes to
> the test in the past.  I think we're two short for the listener on #one, and
> also two short for the listener on the root.  But we're two over for #seven
> since that listener doesn't call finished_test (and also doesn't check for
> duplicate events on ::after).
> 
> It might be worth seeing if adding the necessary calls makes failures that
> are currently intermittent more reliable.
This should fix the main failure mode in bug 1156451, which is results
from the transition on #four (the last transition that completes)
happening after SimpleTest.finish().
Attachment #8600891 - Flags: review?(bzbarsky)
Comment on attachment 8600890 [details] [diff] [review]
patch 1 - Add comments for existing started_test() calls

r=me
Attachment #8600890 - Flags: review?(bzbarsky) → review+
Comment on attachment 8600891 [details] [diff] [review]
patch 2 - Fix unbalanced start_test()/finished_test() calls

r=me
Attachment #8600891 - Flags: review?(bzbarsky) → review+
Comment on attachment 8600892 [details] [diff] [review]
patch 3 - Check that we don't get duplicate events for #seven::after

r=me

Thank you for doing this!
Attachment #8600892 - Flags: review?(bzbarsky) → review+
You need to log in before you can comment on or make changes to this bug.