Closed
Bug 1161056
Opened 9 years ago
Closed 9 years ago
[GTK3] Combobox has no background color
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file, 1 obsolete file)
2.95 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
Combo Boxes (as well as buttons) does not have a background color in Gtk3. The background color is actually fully transparent what causes rendering bugs in dark color theme. It makes sense to follow GtkButton case and use window color.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8600915 -
Flags: review?(karlt)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → stransky
Comment 2•9 years ago
|
||
Comment on attachment 8600915 [details] [diff] [review] patch Please keep the code involving sComboBoxText. I assume the text foreground color can't be transparent, and we did that for button. Ideally the window background color would only be used if the combobox background is actually transparent, but I'm OK with switching to the window background, and we can deal with non-transparent comboboxes later if they are ever a problem.
Attachment #8600915 -
Flags: review?(karlt) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Thanks, there's a new one.
> Ideally the window background color would only be used if the combobox
> background is actually transparent, but I'm OK with switching to the window
> background, and we can deal with non-transparent comboboxes later if they
> are ever a problem.
I'm not sure the transparency is actually supported by Gtk or the widgets are supposed to be transparent. AFAIK the background of most elements (buttons and so) is transparent to avoid double paint.
I'd use the simple model now and update all widgets for the transparency when it's supported/used by Gtk.
Attachment #8600915 -
Attachment is obsolete: true
Attachment #8601550 -
Flags: review?(karlt)
Updated•9 years ago
|
Attachment #8601550 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8601550 [details] [diff] [review] patch v.2 Thanks. try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=90d47673da38
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Martin Stránský from comment #4) > Comment on attachment 8601550 [details] [diff] [review] > patch v.2 > > Thanks. try run: > https://treeherder.mozilla.org/#/jobs?repo=try&revision=90d47673da38 Sorry, wrong patch. Correct one is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=66f93d268fd4
https://hg.mozilla.org/mozilla-central/rev/67b8e70ddf45
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•