[GTK3] Combobox has no background color

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

Trunk
mozilla40
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Combo Boxes (as well as buttons) does not have a background color in Gtk3. The background color is actually fully transparent what causes rendering bugs in dark color theme. It makes sense to follow GtkButton case and use window color.
(Assignee)

Comment 1

4 years ago
Created attachment 8600915 [details] [diff] [review]
patch
Attachment #8600915 - Flags: review?(karlt)
(Assignee)

Updated

4 years ago
Assignee: nobody → stransky
Comment on attachment 8600915 [details] [diff] [review]
patch

Please keep the code involving sComboBoxText.
I assume the text foreground color can't be transparent, and we did that for button.

Ideally the window background color would only be used if the combobox background is actually transparent, but I'm OK with switching to the window background, and we can deal with non-transparent comboboxes later if they are ever a problem.
Attachment #8600915 - Flags: review?(karlt) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8601550 [details] [diff] [review]
patch v.2

Thanks, there's a new one. 

> Ideally the window background color would only be used if the combobox
> background is actually transparent, but I'm OK with switching to the window
> background, and we can deal with non-transparent comboboxes later if they
> are ever a problem.

I'm not sure the transparency is actually supported by Gtk or the widgets are supposed to be transparent. AFAIK the background of most elements (buttons and so) is transparent to avoid double paint. 

I'd use the simple model now and update all widgets for the transparency when it's supported/used by Gtk.
Attachment #8600915 - Attachment is obsolete: true
Attachment #8601550 - Flags: review?(karlt)
Attachment #8601550 - Flags: review?(karlt) → review+
(Assignee)

Comment 5

4 years ago
(In reply to Martin Stránský from comment #4)
> Comment on attachment 8601550 [details] [diff] [review]
> patch v.2
> 
> Thanks. try run:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=90d47673da38

Sorry, wrong patch. Correct one is here:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=66f93d268fd4
(Assignee)

Comment 6

4 years ago
try looks good.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/67b8e70ddf45
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.