1161079 - Logging of encoder stats in WebRTC broken by multistream landing

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

+++ This bug was initially created as a clone of Bug #1159489 +++

Spun off the issue with encoder stats being broken since multistream landedi n Fx38 found in bug 1159489

Patch is already r=jib

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Fix VideoCodecStats to allow for collecting encoder and decoder stats

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8600948 [details] [diff] [review]
Fix VideoCodecStats to allow for collecting encoder and decoder stats

Carry forward r=jib

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10c082aa3a63

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/10c082aa3a63

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8600948 [details] [diff] [review]
Fix VideoCodecStats to allow for collecting encoder and decoder stats

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:

I want this for ESR since this enhances the ability of users to report issues with WebRTC.

[Feature/regressing bug #]: Bug 1130534 (merging video conduits)

[User impact if declined]: No encoder stats are available for about:webrtc

[Describe test coverage new/current, TreeHerder]: Manual testing of about:webrtc

[Risks and why]: quite low risk; just ensures it registers for all the appropriate callbacks instead of only the first (of decoder or encoder)

[String/UUID change made/needed]: none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8600948 [details] [diff] [review]
Fix VideoCodecStats to allow for collecting encoder and decoder stats

Approved for uplift to aurora.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

ESR 38.0 already was built on Monday. So unless this is a security fix it may need to wait for the next release of ESR (38.1).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b0ea2bcdc84

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr38/rev/9ed9a0b91467