1161134 - Suggest using AppConstants.BROWSER_INTENT_CLASS_NAME instead of BrowserApp.class

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nathan Toone [:toonetown]]

When setting up new intents, in a couple of places, the class name on the intent is set directly to BrowserApp.class.

Most places, however, use Intent.setClassName(AppConstants.ANDROID_PACKAGE_NAME, AppConstants.BROWSER_INTENT_CLASS_NAME).  I would suggest that would be a better approach, because if the name of the browser intent changes (i.e. when doing branding, etc), then it is a single place to be updated (in AppConstants).

Comment 1

[Nathan Toone [:toonetown]]

Attachment: bug-1161134.diff

First stab at using the AppConstants value instead of setting the class directly.  I believe this is a better approach.

Comment 2

[Nathan Toone [:toonetown]]

Try server https://treeherder.mozilla.org/#/jobs?repo=try&revision=c809da8c5432

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8601012 [details] [diff] [review]
bug-1161134.diff

Review of attachment 8601012 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  If try is green, roll on.

Comment 4

[Nathan Toone [:toonetown]]

Build is green (tests are still running), but I don't have commit access.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2cf04909a23b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/2cf04909a23b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cf04909a23b