Closed Bug 1161134 Opened 4 years ago Closed 4 years ago

Suggest using AppConstants.BROWSER_INTENT_CLASS_NAME instead of BrowserApp.class

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: toonetown, Assigned: toonetown)

References

Details

Attachments

(1 file)

When setting up new intents, in a couple of places, the class name on the intent is set directly to BrowserApp.class.

Most places, however, use Intent.setClassName(AppConstants.ANDROID_PACKAGE_NAME, AppConstants.BROWSER_INTENT_CLASS_NAME).  I would suggest that would be a better approach, because if the name of the browser intent changes (i.e. when doing branding, etc), then it is a single place to be updated (in AppConstants).
Assignee: nobody → nathan
Attached patch bug-1161134.diffSplinter Review
First stab at using the AppConstants value instead of setting the class directly.  I believe this is a better approach.
Attachment #8601012 - Flags: review?(nalexander)
Comment on attachment 8601012 [details] [diff] [review]
bug-1161134.diff

Review of attachment 8601012 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  If try is green, roll on.
Attachment #8601012 - Flags: review?(nalexander) → review+
Status: NEW → ASSIGNED
OS: Unspecified → Android
Hardware: Unspecified → All
Summary: Suggest using AppConstants.BROWSER_INTNET_CLASS_NAME instead of BrowserApp.class → Suggest using AppConstants.BROWSER_INTENT_CLASS_NAME instead of BrowserApp.class
Build is green (tests are still running), but I don't have commit access.
Keywords: checkin-needed
Blocks: 1161195
https://hg.mozilla.org/mozilla-central/rev/2cf04909a23b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.