1161206 - Allow synthesizing native mouse wheel events on OS X

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

In order to properly exercise the APZ code we need to be able to synthesize and dispatch native events on desktop platforms. The stubs for these already exist (see nsIDOMWindowUtils::sendNative*) but they are not implemented across all platforms. This bug is specifically about implementing SynthesizeNativeMouseScrollEvent on OS X.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This implements the function

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Test that exercises it

This is a test that exercises the native synthesization function in the other patch. It's a modified version of the test I added in bug 1013432, that uses native event synthesization. This test passes for me locally under the following configurations on OS X:

./mach mochitest-plain gfx/layers/apz/test/test_wheel_scroll.html
./mach mochitest-plain --e10s gfx/layers/apz/test/test_wheel_scroll.html
./mach mochitest-plain --e10s --setpref=layers.async-pan-zoom.enabled=true gfx/layers/apz/test/test_wheel_scroll.html

I want to test it on windows too before flagging for review.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8601076 [details] [diff] [review]
Patch

Review of attachment 8601076 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +1211,5 @@
> +    (aAdditionalFlags & nsIDOMWindowUtils::MOUSESCROLL_SCROLL_LINES)
> +    ? kCGScrollEventUnitLine : kCGScrollEventUnitPixel;
> +  CGEventRef cgEvent = CGEventCreateScrollWheelEvent(NULL, units, 3, aDeltaY, aDeltaX, aDeltaZ);
> +  if (!cgEvent)
> +    return NS_ERROR_FAILURE;

{}

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Test v2

Updated test to be more robust. It passes locally for me on OS X and windows, using all the configurations I listed in comment 2

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=11fd6584a02e - will wait for that to go green before requesting review. (Also I'll need to disable the test on non-(mac+windows) platforms).

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Test v3

Try push has this test passing on mac and windows as expected, and failing on linux as expected. Updated mochitest.ini to only run on cocoa/windows toolkits.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d3859a249b
https://hg.mozilla.org/integration/mozilla-inbound/rev/510299530155

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b0d3859a249b
https://hg.mozilla.org/mozilla-central/rev/510299530155