Closed
Bug 1161209
Opened 10 years ago
Closed 10 years ago
Release marionette-driver 0.7 and marionette-client 0.13
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
(Keywords: pi-marionette-client)
Attachments
(1 file)
1.42 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
We need to release new versions of marionette-driver and marionette-client to pick up the changes from bug 1149618, before we can update gaiatest to not depend on SpecialPowers (bug 1150755).
Updated•10 years ago
|
Keywords: ateam-marionette-client
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8601729 -
Flags: review?(dburns)
Assignee | ||
Comment 2•10 years ago
|
||
try run to make sure this doesn't break Gip: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ef7bd1c237f
Assignee | ||
Comment 3•10 years ago
|
||
Dave, can you tell whether this would be harmless to on-device tests for B2G?
Flags: needinfo?(dave.hunt)
Assignee | ||
Comment 4•10 years ago
|
||
The only changes in this bump are from bug 1149618.
Comment 5•10 years ago
|
||
Landing this will be harmless, however in the current state any new release of marionette-driver will be picked up by gaiatest (via an unpinned dependency in marionette-client). I suggest pinning marionette-driver in gaiatest, releasing, and then bumping the pinned dependency at the same time as landing the necessary changes. That said, if there are no backwards incompatible changes to marionette-driver, a release will also be harmless.
Flags: needinfo?(dave.hunt)
Comment 6•10 years ago
|
||
I just tested in-tree marionette-driver with PyPI's latest marionette-client and in-tree gaiatest (which is the combination Jenkins would run if marionette-driver was released now) and had the following failure:
TEST-UNEXPECTED-ERROR | test_delete_all_contacts.py TestDeleteAllContacts.test_delete_all_contacts | JavascriptException: JavascriptException: TypeError: Components.classes is undefined
stacktrace:
execute_script @gaia_test.py, line 676
inline javascript, line 1097
src: " _accRetrieval: Components.classes["
Traceback (most recent call last):
File "/Users/dhunt/.virtualenvs/gaiatest-master/lib/python2.7/site-packages/marionette/marionette_test.py", line 277, in run
self.setUp()
File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_delete_all_contacts.py", line 13, in setUp
GaiaTestCase.setUp(self)
File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 852, in setUp
self.cleanup_gaia(full_reset=False)
File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 887, in cleanup_gaia
self.device.turn_screen_off()
File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 676, in turn_screen_off
ret = self.marionette.execute_script("window.wrappedJSObject.ScreenManager.turnScreenOff(true)")
File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 1452, in execute_script
filename=os.path.basename(frame[0]))
File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/decorators.py", line 36, in _
return func(*args, **kwargs)
File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 711, in _send_message
self._handle_error(response)
File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 747, in _handle_error
raise errors.lookup(status)(message, stacktrace=stacktrace)
TEST-INFO took 49890ms
Assignee | ||
Comment 7•10 years ago
|
||
Yes, I'll make a patch to pin marionette-driver in gaiatest, then after _that_ lands, I'll do these version bumps.
Assignee | ||
Comment 8•10 years ago
|
||
Ok, gaiatest is pinned, so landing/releasing this shouldn't cause any problems.
Updated•10 years ago
|
Attachment #8601729 -
Flags: review?(dburns) → review+
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → mozilla40
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/98a6cb62aeff
whoops, wrong bug!
Comment 11•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Assignee | ||
Comment 13•10 years ago
|
||
FTR, I'm going to release these to PyPI on Monday, in case there is unexpected bustage for out-of-tree tests.
Assignee | ||
Comment 14•10 years ago
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
Comment 15•2 years ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•