Release marionette-driver 0.7 and marionette-client 0.13

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

({pi-marionette-client})

unspecified
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

We need to release new versions of marionette-driver and marionette-client to pick up the changes from bug 1149618, before we can update gaiatest to not depend on SpecialPowers (bug 1150755).
try run to make sure this doesn't break Gip:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ef7bd1c237f
Dave, can you tell whether this would be harmless to on-device tests for B2G?
Flags: needinfo?(dave.hunt)
The only changes in this bump are from bug 1149618.
Landing this will be harmless, however in the current state any new release of marionette-driver will be picked up by gaiatest (via an unpinned dependency in marionette-client). I suggest pinning marionette-driver in gaiatest, releasing, and then bumping the pinned dependency at the same time as landing the necessary changes. That said, if there are no backwards incompatible changes to marionette-driver, a release will also be harmless.
Flags: needinfo?(dave.hunt)
I just tested in-tree marionette-driver with PyPI's latest marionette-client and in-tree gaiatest (which is the combination Jenkins would run if marionette-driver was released now) and had the following failure:

TEST-UNEXPECTED-ERROR | test_delete_all_contacts.py TestDeleteAllContacts.test_delete_all_contacts | JavascriptException: JavascriptException: TypeError: Components.classes is undefined
stacktrace:
	execute_script @gaia_test.py, line 676
	inline javascript, line 1097
	src: "  _accRetrieval: Components.classes["
Traceback (most recent call last):
  File "/Users/dhunt/.virtualenvs/gaiatest-master/lib/python2.7/site-packages/marionette/marionette_test.py", line 277, in run
    self.setUp()
  File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_delete_all_contacts.py", line 13, in setUp
    GaiaTestCase.setUp(self)
  File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 852, in setUp
    self.cleanup_gaia(full_reset=False)
  File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 887, in cleanup_gaia
    self.device.turn_screen_off()
  File "/Users/dhunt/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 676, in turn_screen_off
    ret = self.marionette.execute_script("window.wrappedJSObject.ScreenManager.turnScreenOff(true)")
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 1452, in execute_script
    filename=os.path.basename(frame[0]))
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 711, in _send_message
    self._handle_error(response)
  File "/Users/dhunt/workspace/mozilla/mozilla-central/testing/marionette/driver/marionette_driver/marionette.py", line 747, in _handle_error
    raise errors.lookup(status)(message, stacktrace=stacktrace)
TEST-INFO took 49890ms
Yes, I'll make a patch to pin marionette-driver in gaiatest, then after _that_ lands, I'll do these version bumps.
Depends on: 1162131
Ok, gaiatest is pinned, so landing/releasing this shouldn't cause any problems.
Attachment #8601729 - Flags: review?(dburns) → review+
Target Milestone: --- → mozilla40
(In reply to Jonathan Griffin (:jgriffin) from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/98a6cb62aeff

whoops, wrong bug!
https://hg.mozilla.org/mozilla-central/rev/f8859779e97c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
FTR, I'm going to release these to PyPI on Monday, in case there is unexpected bustage for out-of-tree tests.
You need to log in before you can comment on or make changes to this bug.