Closed
Bug 116124
Opened 23 years ago
Closed 17 years ago
remove duplicated conversion utils in nsMsgI18N.cpp
Categories
(MailNews Core :: Internationalization, defect)
MailNews Core
Internationalization
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nhottanscp, Assigned: smontagu)
References
Details
nsMsgI18NConvertFromUnicode and nsMsgI18NConvertToUnicode are redundant and some
of the callers are using them for UTF-8 <-> UCS2 conversions which can call
xpcom utils (e.g. NS_ConvertUTF8toUCS2) and avoid overhead of creating the
converters.
|
Reporter | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
|
|
Reporter | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.2
|
|
Reporter | |
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → ---
|
||
Updated•20 years ago
|
Product: MailNews → Core
|
||
Comment 1•17 years ago
|
||
Is this still relevant? I think the plain misuse have been removed...
nsMsgI18NConvertToUnicode could use ConvertToUnicode instead - which is inlined return nsMsgI18NConvertToUnicode(....) - but I can't tell if that's useful.
Assignee: nhottanscp → smontagu
Status: ASSIGNED → NEW
QA Contact: ji → mailnews.i18n
|
Assignee | |
Comment 2•17 years ago
|
||
Yeah, Jungshik's fixes for bug 228543 and bug 229032 covered this.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/mailnews/base/util&command=DIFF_FRAMESET&file=nsMsgI18N.cpp&rev2=1.85&rev1=1.84
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=/mozilla/mailnews/base/util&command=DIFF_FRAMESET&file=nsMsgI18N.cpp&rev2=1.88&rev1=1.87
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•