1161307 - Disabled addon notice due to safe mode does not extend to the right edge

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: screenshot

The disabled addon notice due to safe mode does not extend to the right edge, and it probably should. Thanks to :MattN for letting me know that this is a bug. :)

Comment 1

[Richard Marti (:Paenglab)]

The problem is, The page should have on the right (or better on all four sides) a margin of 48px like the notice has. But the add-on list needs to have no margin to position the scrollbar at the edge. This makes the focus ring also extend to the edge which gives the appearance the notice is too short.

I don't see how this could be fixed except we remove the focus ring.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug1161307.patch

Found a solution to move the focusring to the .scrollbox-innerbox.

Is this something we can do? The only issue is, when the scrollbar appears, the focusring is shifted to the left for the scrollbar width. But maybe bug 1037859 shows a solution which could be copied.

Comment 3

[Dave Townsend [:mossop] (PTO until July 20)]

I'm not sure this is the right solution. Why do we have the scrollbar separated off from the list items like this anyway?

Comment 4

[Richard Marti (:Paenglab)]

I can't find it now but during the in-content prefs styling the appearing of the scrollbar somewhere in the page (there is no color delimitation like on the old add-on manager styling) was rejected from UX.

Comment 5

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8601579 [details] [diff] [review]
Bug1161307.patch

Review of attachment 8601579 [details] [diff] [review]:
-----------------------------------------------------------------

Ok I guess let's go with this.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/0a7e10d3e9af

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a7e10d3e9af