1161330 - WebIDE does not work without remote=true on iframes

Status: RESOLVED WONTFIX

(DevTools Graveyard :: WebIDE, defect)

Description

[Kevin Grandon :kgrandon]

This could potentially be a horizon config issue, but filing this under WebIDE to start the investigation. Horizon is basically graphene with a few config/branding changes. When trying to connect to it, I see the following error:

onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'listTabs: TypeError: browser.getTabBrowser is not a function\nStack: BrowserTabList.prototype._getActorForBrowser@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:376:1\nBrowserTabList.prototype.getList@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:345:7\nRootActor.prototype.onListTabs@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/root.js:232:12\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1456:15\nDebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/transport/transport.js:471:9\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14\nLine: 376, column: 0"}
Stack: DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:944:1
DebuggerTransport.prototype._onJSONObjectReady/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:471:9
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
Line: 944, column: 0

Trying to connect from: Firefox Nightly, 40.0a1 (2015-05-04)

Comment 1

[Kevin Grandon :kgrandon]

Paul - is this currently working for browser.html? Does this stack bring anything to mind?

Comment 2

[Paul Rouget [:paul]]

I just built larch and updated firefox nightly.
It appears to work for me.

Did you build the larch branch as it is, or did you merge the larch branch into a recent m-c?

Comment 3

[Kevin Grandon :kgrandon]

We are basically using the larch branch mostly as-is, but adding some customizations on top of it with these commits: https://github.com/KevinGrandon/gecko-projects/pull/4

Comment 4

[Paul Rouget [:paul]]

Looks like it should work exactly like Graphene. Just to make sure, can you build without these commits?

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Screenshot after trying to connect with webIDE

Here's a screenshot of what we see after trying to connect. I see an item in the menu for "Main Process", but there is no system app listed to debug. Connecting to the main process also results in a timeout.

(In reply to Paul Rouget [:paul] from comment #4)
> Looks like it should work exactly like Graphene. Just to make sure, can you
> build without these commits?

Ok, I gave it a test and I was able to connect to a vanilla Graphene install, it's only when I add those commits is when things go wrong. I'm wondering if it's a difference in the start manifest content, or if something is hard-coded on the gecko side.

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Kevin Grandon :kgrandon from comment #5)
> 
> Ok, I gave it a test and I was able to connect to a vanilla Graphene
> install, it's only when I add those commits is when things go wrong. I'm
> wondering if it's a difference in the start manifest content, or if
> something is hard-coded on the gecko side.

Does that work with a graphene build starting with --start-manifest=https://mozilla.github.io/browser.html/manifest.webapp ?

Comment 7

[Kevin Grandon :kgrandon]

Turns out our iframes did not have the 'remote' property which is required for WebIDE to work it appears. I've got this working for the time being, but it does seem like a bug with WebIDE to me. Updating the title to track this (or you can file a new bug and close this).

Comment 8

[Alexandre Poirot [:ochameau]]

Main process debugging doesn't work??
I don't see exactly what is broken here.
Or is there a app in graphene, you try to select in app menu in webide and it doesn't work connecting to this app?

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Alexandre Poirot [:ochameau] from comment #8)
> Main process debugging doesn't work??
> I don't see exactly what is broken here.
> Or is there a app in graphene, you try to select in app menu in webide and
> it doesn't work connecting to this app?

The apps don't appear in WebIDE when they don't have the remote='true' attribute on them. This also seems to break WebIDE - you can't debug the main process.

Comment 10

[Paul Rouget [:paul]]

In BrowserTabList.prototype._getActorForBrowser (server/actors/webbrowser.js), we assume that if a browser is a non-remote browser, then it must be a Firefox Desktop tab. `browser.getTabBrowser` is a <xbl:browser> function.

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

WebIDE is slated for removal (bug 1314811), so there are no plans to add to the current set of features.