1161353 - Remove the post-barrier verifier

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

It hasn't caught anything in almost 2 years, it requires an annoying amount of code outside Verifiers.cpp, and it's going to be highly annoying to continue supporting it once we move nursery marking off the callback tracer.

Comment 1

[Terrence Cole [:terrence]]

Attachment: remove_postbarrier_verifier-v0.diff

Comment 2

[Terrence Cole [:terrence]]

Note: this is JS_GC_ZEAL=11 and 12.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8601697 [details] [diff] [review]
remove_postbarrier_verifier-v0.diff

Review of attachment 8601697 [details] [diff] [review]:
-----------------------------------------------------------------

Ooh! I bet this eliminates the one horrible nasty special case thing I had to do for gc::Statistics!

::: js/src/gc/GCInternals.h
@@ -126,3 @@
>  
>          if (outer != gcstats::PHASE_NONE)
>              gc->stats.beginPhase(outer);

The gc->stats.endPhase and gc->stats.beginPhase are the things that might be able to go now, but maybe they're still needed for the prebarrier verifier? Not sure.

Not for this patch, anyway. But if it could go, then it would also eliminate some awkward phase tracking (saving/restoring). I'll have to take a look after this lands.

Comment 4

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db59d84dabf

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49472c04d816

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8601697 [details] [diff] [review]
remove_postbarrier_verifier-v0.diff

Didn't find anything terrible overnight yet.

Comment 7

[Terrence Cole [:terrence]]

Thanks Gary!

Comment 8

[Jon Coppeard (:jonco)]

Attachment: remove-more-post-barrier-verifier

Remove some more vestiges of the post barrier verifier.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49472c04d816

Comment 10

[Terrence Cole [:terrence]]

Comment on attachment 8602670 [details] [diff] [review]
remove-more-post-barrier-verifier

Review of attachment 8602670 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I have about half of these sitting in a patch. I still didn't remove verifyPostData though: can't believe I missed that.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/033d22094200

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/033d22094200