Closed Bug 1161353 Opened 5 years ago Closed 5 years ago

Remove the post-barrier verifier

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox40 --- affected

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It hasn't caught anything in almost 2 years, it requires an annoying amount of code outside Verifiers.cpp, and it's going to be highly annoying to continue supporting it once we move nursery marking off the callback tracer.
Blocks: 1161726
Attachment #8601697 - Flags: review?(sphink)
Attachment #8601697 - Flags: feedback?(gary)
Attachment #8601697 - Flags: feedback?(choller)
Note: this is JS_GC_ZEAL=11 and 12.
Comment on attachment 8601697 [details] [diff] [review]
remove_postbarrier_verifier-v0.diff

Review of attachment 8601697 [details] [diff] [review]:
-----------------------------------------------------------------

Ooh! I bet this eliminates the one horrible nasty special case thing I had to do for gc::Statistics!

::: js/src/gc/GCInternals.h
@@ -126,3 @@
>  
>          if (outer != gcstats::PHASE_NONE)
>              gc->stats.beginPhase(outer);

The gc->stats.endPhase and gc->stats.beginPhase are the things that might be able to go now, but maybe they're still needed for the prebarrier verifier? Not sure.

Not for this patch, anyway. But if it could go, then it would also eliminate some awkward phase tracking (saving/restoring). I'll have to take a look after this lands.
Attachment #8601697 - Flags: review?(sphink) → review+
Comment on attachment 8601697 [details] [diff] [review]
remove_postbarrier_verifier-v0.diff

Didn't find anything terrible overnight yet.
Attachment #8601697 - Flags: feedback?(gary) → feedback+
Thanks Gary!
Remove some more vestiges of the post barrier verifier.
Attachment #8602670 - Flags: review?(terrence)
Keywords: leave-open
Comment on attachment 8602670 [details] [diff] [review]
remove-more-post-barrier-verifier

Review of attachment 8602670 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I have about half of these sitting in a patch. I still didn't remove verifyPostData though: can't believe I missed that.
Attachment #8602670 - Flags: review?(terrence) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Attachment #8601697 - Flags: feedback?(choller)
You need to log in before you can comment on or make changes to this bug.