crash in FontFace.load when loading a second face for a font using unicode-range

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

The attachment will crash Firefox with a null pointer dereference if the Font Loading API is enabled (as it is currently on Nightly/Aurora).
This is because we're parsing the font descriptor values passing null for the sheet URI.  The sheet URI gets stored in the URLValue, and then copied into the gfxFontFaceSrc object, where its operator== assumes that it is non-null.
Posted patch patchSplinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8601252 - Flags: review?(dbaron)
Blocks: 1149381
Comment on attachment 8601252 [details] [diff] [review]
patch

Maybe call the variable docURI instead of just uri?

r=dbaron
Attachment #8601252 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/0faf5cdec061
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.