1161440 - [Presentation WebAPI] trusted UI for device selection on Firefox OS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::System UI, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We need a trusted UI for device selection in order to implement Presentation WebAPI.

The available device list can be obtained via navigator.mozPresentationDeviceInfo API [1]. The device selection event/result will be delivered via mozChromeEvent/mozContentEvent, see [2] for more detail.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/webidl/PresentationDeviceInfoManager.webidl
[2] https://dxr.mozilla.org/mozilla-central/source/b2g/components/B2GPresentationDevicePrompt.js#62

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

This bug is for Firefox OS device as controller (e.g. phone). Do we have any user story for b2g phone controlling TV?

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

we only have these for now but yes i think it will be a good idea to have a b2g/desktop user story as well
Bug 1187861 - [TV 2.5] Control video or audio playback on TV from Fennec 
Bug 1187863 - [TV 2.5] Display “remote control my TV” icon on Fennec when compatible TV is around

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: [WIP] gaia.patch

This is a WIP for Mozlando demo. I reuse multi_screen_controller.js so it can handle both device selection for both Presentation API and multi screen.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] schien:bug1161440 > mozilla-b2g:master

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

Looks good except some nits. Please take a look at my comments on GitHub. Thanks.

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

patch updated according to review comments.

Comment 7

[Luke Chang [:lchang] (inactive)]

I left some questions on GitHub. Thanks.

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Thanks for the quick review. patch updated again!

Comment 9

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

Looks good now. Thanks.

Comment 10

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We still need some more gecko patches to default enable presentation API on B2G phone. I decided to remove the change in settings.json and custom-prefs.js so that we can land UI code first. @lchang how do you think?

Comment 11

[Luke Chang [:lchang] (inactive)]

It's totally fine for me.

Comment 12

[Luke Chang [:lchang] (inactive)]

The test of MultiScreenController is failed:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=196483fe13bdeb95b4de53b6224cfe0858f375d6&selectedJob=3091177

Would you mind fixing it before landing? Also, it would be better if you add some unit tests for protecting your code.

Comment 13

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

test case updated, request for review again.

Comment 14

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

It's almost done except some suggestions on GitHub.

Comment 15

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

update according to review comments.

Comment 16

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8692808 [details] [review]
[gaia] schien:bug1161440 > mozilla-b2g:master

Looks great! Thanks.

Comment 17

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2d9da26345657bc218540d41cb90e19ab5de2197

landed on master: https://github.com/mozilla-b2g/gaia/commit/694f04b32f7133bb1b6f9aa3145e29653212319b