116147 - meta bug: summary for reviews/super-reviews of FreeType2 checkin

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[kill this account]

this bug is a meta bug to help organize the review process for the FreeType2
code

Comment 1

[kill this account]

the attachments for these bugs are required to make a complete checkin:
bug 116148, bug 116149, bug 116150, bug 116151, bug 116153, bug 116154, and
bug 116155

Comment 2

[kill this account]

The sub bugs have changes/additions to the following files:

bug 116149
 gfx/public/Makefile.in
 gfx/public/nsNameValuePairDB.h
 gfx/src/Makefile.in
 gfx/src/nsNameValuePairDB.cpp

bug 116150
 gfx/public/nsCompressedCharMap.h
 gfx/src/nsCompressedCharMap.cpp

bug 116151
 gfx/src/gtk/nsFreeType.h
 gfx/src/gtk/nsFreeType.cpp

bug 116153
 gfx/src/gtk/nsFontMetricsGTK.cpp
 gfx/src/gtk/nsFontMetricsGTK.h
 modules/libpref/src/unix/unix.js

bug 116154
 gfx/src/gtk/nsFontCatalog.h
 gfx/src/gtk/nsFontCatalog.cpp

bug 116155
 gfx/src/gtk/nsX11AlphaBlend.h
 gfx/src/gtk/nsX11AlphaBlend.cpp
 gfx/src/gtk/nsRenderingContextGTK.cpp
 gfx/src/gtk/nsAntiAliasedGlyph.h
 gfx/src/gtk/nsAntiAliasedGlyph.cpp
 gfx/src/gtk/nsXFontAAScaledBitmap.cpp

Comment 3

[Roland Mainz]

bstell:
Can we put all new files in gfx/src/gtk/ which are not explicitly GTK+-specific
per design into mozilla/gfx/src/x11shared/ , please ?
Otherwise I would have to move the files once I port the code to Xlib toolkit
...
AFAIK this includes
-- snip --
gfx/src/gtk/nsFreeType.h
gfx/src/gtk/nsFreeType.cpp
gfx/src/gtk/nsFontCatalog.h
gfx/src/gtk/nsFontCatalog.cpp
-- snip --

Comment 4

[kill this account]

I will work on this

Comment 5

[kill this account]

Roland: can you create a Makefile.in for this?

Comment 6

[Roland Mainz]

Brian Stell wrote:
> Roland: can you create a Makefile.in for this?

Sure. But it's very easy - look at the Xprint module Makefile.in
(gfx/src/xprint/Makefile.in). The module uses some sources from Xlib toolkit,
follow the usage of the XLIB_LCPPSRCS symbol.

If you have problems then symlink the shared sources from
mozilla/gfx/src/x11shared/ to mozilla/gfx/src/gtk/ in your tree for development,
make the patch and attach it to the matching bug - I'll post the Makefile.in
patch then...

Comment 7

[kill this account]

all the parts have been checked in
marking fixed

Comment 8

[kill this account]

all the parts are in so I'm closing out this "meta" bug