1161481 - Changing the theme will break all transitions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

Description

[Etienne Segonzac (:etienne)]

We should systematically add something like [1] in all generated themes.

[1] https://github.com/gaia-components/gaia-theme/blob/bfc4e8ca5e04530161cad83048002980bb9a238f/gaia-theme.css#L87

Comment 1

[Etienne Segonzac (:etienne)]

We should also update gaia's pre-built demo theme.

Comment 2

[Dietrich Ayala (:dietrich)]

Thanks for spotting, Etienne. I can make a patch if you point me in the general direction of where this code lives!

Comment 3

[Etienne Segonzac (:etienne)]

(In reply to Dietrich Ayala (:dietrich) from comment #2)
> Thanks for spotting, Etienne. I can make a patch if you point me in the
> general direction of where this code lives!

Cool!
For the spark theme editor, the css generation happens here [1].
And we have a few [2] tests [3] themes [4] in the gaia repo.

[1] https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/generation.js#L152-174
[2] https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-1/shared/elements/gaia-theme/gaia-theme.css
[3] https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-2/shared/elements/gaia-theme/gaia-theme.css
[4] https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-3/shared/elements/gaia-theme/gaia-theme.css

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] autonome:1161481-theme-transitions > mozilla-b2g:master

Comment 5

[Dietrich Ayala (:dietrich)]

Looks like I should add the var here in this section:

https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/theme_creator.js#L97

Does that look right, Etienne?

Comment 6

[Etienne Segonzac (:etienne)]

(In reply to Dietrich Ayala (:dietrich) from comment #5)
> Looks like I should add the var here in this section:
> 
> https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/
> js/theme_creator.js#L97
> 
> Does that look right, Etienne?

Not sure. This is the representation of the "editable" part of the theme, which only includes colors currently.
Adding the line around here [1] sounds safer.

[1] https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/generation.js#L161

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8601672 [details] [review]
[gaia] autonome:1161481-theme-transitions > mozilla-b2g:master

This part is already good to go :)

Comment 8

[Dietrich Ayala (:dietrich)]

Attachment: Link to Github pull-request: https://github.com/fxos/studio/pull/6

Like this?

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8602509 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/6

Nice :)

Comment 10

[Etienne Segonzac (:etienne)]

Studio part landed: https://github.com/fxos/studio/commit/1f34fe0047c84257f968852a2d3c0a48ee7fc372

Comment 11

[Etienne Segonzac (:etienne)]

Hope this bug won't confuse autolander too much...

Comment 12

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/29898

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.

Comment 13

[Dietrich Ayala (:dietrich)]

Interesting, autolander picked the right attachment, but failed. Trying again...

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/264429245ee175ba75676b52bd6b63dd9b3d93d3