Closed Bug 1161481 Opened 5 years ago Closed 5 years ago
Changing the theme will break all transitions
46 bytes, text/x-github-pull-request
|Details | Review|
37 bytes, text/x-github-pull-request
|Details | Review|
We should systematically add something like  in all generated themes.  https://github.com/gaia-components/gaia-theme/blob/bfc4e8ca5e04530161cad83048002980bb9a238f/gaia-theme.css#L87
Priority: -- → P1
We should also update gaia's pre-built demo theme.
Thanks for spotting, Etienne. I can make a patch if you point me in the general direction of where this code lives!
(In reply to Dietrich Ayala (:dietrich) from comment #2) > Thanks for spotting, Etienne. I can make a patch if you point me in the > general direction of where this code lives! Cool! For the spark theme editor, the css generation happens here . And we have a few  tests  themes  in the gaia repo.  https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/generation.js#L152-174  https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-1/shared/elements/gaia-theme/gaia-theme.css  https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-2/shared/elements/gaia-theme/gaia-theme.css  https://github.com/mozilla-b2g/gaia/blob/4652ef4d51b499a82165e0e0553814c2c5eecb94/dev_apps/theme-test-3/shared/elements/gaia-theme/gaia-theme.css
Looks like I should add the var here in this section: https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/theme_creator.js#L97 Does that look right, Etienne?
(In reply to Dietrich Ayala (:dietrich) from comment #5) > Looks like I should add the var here in this section: > > https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/ > js/theme_creator.js#L97 > > Does that look right, Etienne? Not sure. This is the representation of the "editable" part of the theme, which only includes colors currently. Adding the line around here  sounds safer.  https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/generation.js#L161
Comment on attachment 8601672 [details] [review] [gaia] autonome:1161481-theme-transitions > mozilla-b2g:master This part is already good to go :)
Attachment #8601672 - Flags: review+
Attachment #8602509 - Flags: review?(etienne)
Comment on attachment 8602509 [details] [review] Link to Github pull-request: https://github.com/fxos/studio/pull/6 Nice :)
Attachment #8602509 - Flags: review?(etienne) → review+
Studio part landed: https://github.com/fxos/studio/commit/1f34fe0047c84257f968852a2d3c0a48ee7fc372
Hope this bug won't confuse autolander too much...
https://github.com/mozilla-b2g/gaia/pull/29898 Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Interesting, autolander picked the right attachment, but failed. Trying again...
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/264429245ee175ba75676b52bd6b63dd9b3d93d3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.