Closed Bug 1161481 Opened 5 years ago Closed 5 years ago

Changing the theme will break all transitions

Categories

(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: etienne, Assigned: dietrich)

References

Details

Attachments

(2 files)

We should systematically add something like [1] in all generated themes.

[1] https://github.com/gaia-components/gaia-theme/blob/bfc4e8ca5e04530161cad83048002980bb9a238f/gaia-theme.css#L87
Priority: -- → P1
We should also update gaia's pre-built demo theme.
Thanks for spotting, Etienne. I can make a patch if you point me in the general direction of where this code lives!
Assignee: nobody → dietrich
Looks like I should add the var here in this section:

https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/theme_creator.js#L97

Does that look right, Etienne?
Flags: needinfo?(etienne)
(In reply to Dietrich Ayala (:dietrich) from comment #5)
> Looks like I should add the var here in this section:
> 
> https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/
> js/theme_creator.js#L97
> 
> Does that look right, Etienne?

Not sure. This is the representation of the "editable" part of the theme, which only includes colors currently.
Adding the line around here [1] sounds safer.

[1] https://github.com/fxos/studio/blob/d10b7864ad0bb1f185ce1349da9be03b861badcf/js/generation.js#L161
Flags: needinfo?(etienne)
Comment on attachment 8601672 [details] [review]
[gaia] autonome:1161481-theme-transitions > mozilla-b2g:master

This part is already good to go :)
Attachment #8601672 - Flags: review+
Comment on attachment 8602509 [details] [review]
Link to Github pull-request: https://github.com/fxos/studio/pull/6

Nice :)
Attachment #8602509 - Flags: review?(etienne) → review+
Hope this bug won't confuse autolander too much...
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/29898

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Interesting, autolander picked the right attachment, but failed. Trying again...
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.