1161492 - [Music] [Front-end] Use independent tabs for each view

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Dominic Kuo [:dkuo]]

Currently the music views share one tabs element on the ui. To fit the new gaia architecture, we need to separate the ui into independent views, and each view should have its own tabs element for switching to different views.

Comment 1

[Hema Koka [:hema]]

Based on music sprint planning, moving to sprint 1 target and assigning to Dominic

Comment 2

[Dominic Kuo [:dkuo]]

Attachment: patch

Comment 3

[Dominic Kuo [:dkuo]]

Comment on attachment 8615258 [details] [review]
patch

Jim,

Okay, I think this patch is ready for review, though it should break some tests which I am trying to fix, And before we have a conclusion for bug 1172820, we better make some progress on this, thanks!

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 8615258 [details] [review]
patch

Update:

I have fixed all the broken tests and kept the tabs in sublist(Bug 1172820 comment 6), the patch is done and ready for review, thanks.

Comment 5

[Hema Koka [:hema]]

Dominic,

Based on sprint planning, adding target to 26th. Please wrap this up and land on NGA changes on branch as discussed.

Thanks
Hema

Comment 6

[Jim Porter (:squib)]

Comment on attachment 8615258 [details] [review]
patch

This looks mostly good, except for one part: We now have 3 different tab bars in the HTML, but still only one `TabBar` object. I think we should turn the existing `TabBar` into a regular class that we can instantiate inside each of the views. I have some more ideas about that on GitHub. Thanks!

Comment 7

[Dominic Kuo [:dkuo]]

Let's wait for the NGA/OGA solution then I will update my patch to fit it.

Comment 8

[Jim Porter (:squib)]

After discussion with Justin, Wilson, and Vivien, we decided to use a single tab bar for all the views, as part of the parent <iframe>.