Closed Bug 1161495 Opened 5 years ago Closed 5 years ago

Remove line-height from the in-content preferences main pane

Categories

(Firefox :: Theme, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 41
Iteration:
41.1 - May 25
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: dao, Assigned: amila.efac, Mentored)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

I don't see what this line-height is good for. Pretty sure we should just remove it:

http://hg.mozilla.org/mozilla-central/annotate/102d0e9aa9e1/browser/themes/shared/incontentprefs/preferences.inc.css#l8
Flags: qe-verify-
Flags: firefox-backlog+
I'd like to be assigned to this bug. someone assign me please.
Assignee: nobody → amila.efac
Attachment #8604465 - Flags: review?(dao)
Comment on attachment 8604465 [details] [diff] [review]
rev1 - removes line height.

Looks good, thanks!
Attachment #8604465 - Flags: review?(dao) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/60d94de8ac69
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/60d94de8ac69
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 41
Iteration: --- → 41.1 - May 25
You need to log in before you can comment on or make changes to this bug.