Closed Bug 1161537 Opened 5 years ago Closed 5 years ago

Intermittent test_dev_mode_activity.html | Got error: undefined - expected PASS

Categories

(Firefox OS Graveyard :: General, defect)

Unspecified
macOS
defect
Not set
normal

Tracking

(firefox39 unaffected, firefox40 fixed, firefox41 fixed, firefox-esr31 unaffected, firefox-esr38 unaffected, b2g-v2.2 unaffected, b2g-master fixed)

RESOLVED FIXED
2.2 S13 (29may)
Tracking Status
firefox39 --- unaffected
firefox40 --- fixed
firefox41 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected
b2g-v2.2 --- unaffected
b2g-master --- fixed

People

(Reporter: cbook, Assigned: fabrice)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-other

https://treeherder.mozilla.org/logviewer.html#?job_id=9566836&repo=mozilla-inbound

04:31:52 INFO - 1107 INFO TEST-UNEXPECTED-FAIL | dom/activities/tests/mochi/test_dev_mode_activity.html | Got error: undefined - expected PASS
Blocks: 1123846
Component: DOM → General
Flags: needinfo?(fabrice)
Product: Core → Firefox OS
Flags: needinfo?(fabrice)
I spent some time looking into this and on m-c I did some retriggers:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=rev4%20macosx%20snow%20leopard%2010.6%20mozilla-central%20opt%20test%20mochitest-other&fromchange=843f6046ee00&tochange=e3d3f273cf88

the first time we see this failure is here:
https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=bf86d6afdff2

this seems obvious as there is one revision which is related to gecko/firefox, so on b2g, I did some retriggers;
https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-searchStr=rev4%20macosx%20snow%20leopard%2010.6%20b2g-inbound%20opt%20test%20mochitest-other&fromchange=f07cb6e7ab45&tochange=ffad198d409b

and the first time we see this error is on the merge from m-c:
https://hg.mozilla.org/integration/b2g-inbound/pushloghtml?changeset=cca08f3dc531

this merge is AFTER we see it on m-c from the b2g-inbound merge.  I am lost as to how to find the root cause here.

I even looked on mozilla-inbound:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Rev4%20MacOSX%20Snow%20Leopard%2010.6%20mozilla-inbound%20opt%20test%20mochitest-other&fromchange=4b6544010bdb&tochange=50608a9c7b09

and the first time this shows up is in a merge:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=50608a9c7b09

this includes the b2g-inbound changes and fx-team changes.  I went onto fx-team and retriggered as well:
https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-searchStr=rev4%20macosx%20snow%20leopard%2010.6%20fx-team%20opt%20test%20mochitest-other&fromchange=18d878c18fa9&tochange=2b0b00fb6411

of course I don't see it on fx-team for any of those changesets.

now I am really lost- is this a result of an interaction between patches on different branches only showing up when we merge?  if that is the case then maybe we point to b2g-inbound:
https://hg.mozilla.org/integration/b2g-inbound/rev/4fbdf2a177ab

and as you know this is a new test which was landed there.

:fabrice, you have a new test which was landed that reproduced 5% of the time, can you help figure out what is going on with this new test?
Flags: needinfo?(fabrice)
ok... I pushed to try with some more logging because I could never reproduce locally, at https://treeherder.mozilla.org/#/jobs?repo=try&revision=adb856e06295

We are racing when saving activities and querying the db, because we don't explicitly wait for the end of the write transaction. Patch coming.
Flags: needinfo?(fabrice)
Ok, I'll land this patch since the try run looks fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc3057ae9d6f
https://hg.mozilla.org/mozilla-central/rev/006dbcb5ed41
Assignee: nobody → fabrice
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Please request Aurora approval on this ASAP.
Flags: needinfo?(fabrice)
Target Milestone: --- → 2.2 S13 (29may)
Attached file 006dbcb5ed41
Approval Request Comment
[Feature/regressing bug #]: New feature from bug 1123846
[User impact if declined]: No user impact but significant orange failure
[Describe test coverage new/current, TreeHerder]: updated test.
[Risks and why]: no risk
[String/UUID change made/needed]: none
Flags: needinfo?(fabrice)
Attachment #8607096 - Flags: approval-mozilla-aurora?
Comment on attachment 8607096 [details]
006dbcb5ed41

Approved for uplift to aurora, looks good on m-c for the last few days.
Attachment #8607096 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.