bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Add TrackedStrategy::SetProp_InlineCache.

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nbp, Assigned: nbp)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8601537 [details] [diff] [review]
Add TrackedStrategy::SetProp_InlineCache.
Attachment #8601537 - Flags: review?(shu)

Comment 2

3 years ago
Comment on attachment 8601537 [details] [diff] [review]
Add TrackedStrategy::SetProp_InlineCache.

Review of attachment 8601537 [details] [diff] [review]:
-----------------------------------------------------------------

I originally didn't add one since for SETPROP, the IC is the last strategy and always succeeds. This is opposed to GETPROP ICs, which can fail to be emitted, and the final slow path is a VM call.

Currently, the final attempted strategy is not tracked for anything, since it will always be emitted.

I think in reality, this just has been confusing and maybe we should be tracking the final slow paths everywhere.
Attachment #8601537 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/1ab2d798c5bb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.