Closed
Bug 1161584
Opened 9 years ago
Closed 9 years ago
Add TrackedStrategy::SetProp_InlineCache.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
2.62 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8601537 -
Flags: review?(shu)
Comment 2•9 years ago
|
||
Comment on attachment 8601537 [details] [diff] [review] Add TrackedStrategy::SetProp_InlineCache. Review of attachment 8601537 [details] [diff] [review]: ----------------------------------------------------------------- I originally didn't add one since for SETPROP, the IC is the last strategy and always succeeds. This is opposed to GETPROP ICs, which can fail to be emitted, and the final slow path is a VM call. Currently, the final attempted strategy is not tracked for anything, since it will always be emitted. I think in reality, this just has been confusing and maybe we should be tracking the final slow paths everywhere.
Attachment #8601537 -
Flags: review?(shu) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ab2d798c5bb
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•