1161597 - [webextension] Flashgot items missing from contextual menus

Status: RESOLVED INCOMPLETE

(Firefox :: Extension Compatibility, defect)

Description

[Paul [pwd]]

Flashgot works perfectly using a non-e10s session but once e10s is enabled, you can no longer see the Flashgot contextual menu items such as "FlashGot link" and "FlashGot Selection".

Comment 1

[Tracy Walker [:tracy]]

Paul, can you reproduce this with only Flashgot enabled in your addons?

Comment 2

[Paul [pwd]]

Yes I can indeed Tracy.

Comment 3

[Tracy Walker [:tracy]]

ok, tracking-e10s + 

Will also add it to arewee10syet spreadsheet.

Giorgio, are FlashGot and FlashGot Mass Downloader two different addons or one in the same?

Comment 4

[Giorgio Maone [:ma1]]

They're the same (FlashGot was renamed at some point to be more self-explaining).
Already working on it (a lot of DOM manipulation to populate that menu), taking ownership of this bug.

Comment 5

[avada]

It looks like flashgot selection doesn't work with the hotkey either. (ctrl+f2) It's quite frustrating because I use it a lot normally.

(In reply to Giorgio Maone from comment #4)
> Already working on it (a lot of DOM manipulation to populate that menu),
> taking ownership of this bug.

Is there a dev/beta/whatever build? I can't find any.

Comment 6

[Michelle Funches - QA]

Attachment: No_E10s.png;;

Comment 7

[Michelle Funches - QA]

Attachment: Yes_E10s.png

Comment 8

[Michelle Funches - QA]

We are testing for E10s "Are We E10s Ready, attached screen shots show there context menu the same (E10s Enabled/Disabled)
Can we get more specific steps and websites? Thanks

Comment 9

[avada]

(In reply to Michelle Funches - QA from comment #8)
> We are testing for E10s "Are We E10s Ready, attached screen shots show there
> context menu the same (E10s Enabled/Disabled)
> Can we get more specific steps and websites? Thanks

A new version was released just a week ago. This bug is almost a year old.

>v 1.5.6.13
>=====================================================
>+ e10s-compatible API
>+ Video DownloadHelper integration
>x Restored Nightly compatibility broken by bug 1253016

Comment 10

[:shell escalante]

hi giorgio,  going through add-ons now and wanted to know if this should be re-assigned or if you were working on this on?  i remember needing native script API was the biggest blocker - and that landed - but forgot history and why it was assigned to you =]

Comment 11

[Giorgio Maone [:ma1]]

(In reply to :shell escalante from comment #10)
> wanted to know if this should be
> re-assigned or if you were working on this on?

I've put this in the back-burner because my user population ratios on Nightly suggested to prioritize NoScript (and WebExtensions, of course), but I'm still the most likely person to fix it and I've already planned to do it before the end of August, so please keep it assigned to me.

Comment 12

[:shell escalante]

thanks Giorgio - will do =]

Comment 13

[avada]

(In reply to Giorgio Maone [:mao] from comment #11)
> I've put this in the back-burner because my user population ratios on
> Nightly suggested to prioritize NoScript (and WebExtensions, of course), but
> I'm still the most likely person to fix it and I've already planned to do it
> before the end of August, so please keep it assigned to me.

Will, the fix also adress the non-functioning flashgot selection feature (ctrl+f2) shortcut? I'm missing that one for ages now.

Comment 14

[Michelle Funches - QA]

QA Update:
Working e10s enabled and disabled
btw: please clarify: I see Ctrl + F3 working, was comment 13 meant to reflect Ctrl F2 or is it now F3 due to updates?
Version 	51.0a2
Build ID 	20160929004005
User Agent 	Mozilla/5.0 (X11; Linux i686; rv:51.0) Gecko/20100101 Firefox/51.0
"ni" me if additional info or testing is needed

Comment 15

[Andy McKay]

Might have been wanting to needinfo avada, not me.

Comment 16

[avada]

(In reply to Michelle Funches - QA from comment #14)
> QA Update:
> Working e10s enabled and disabled
> btw: please clarify: I see Ctrl + F3 working, was comment 13 meant to
> reflect Ctrl F2 or is it now F3 due to updates?
> Version 	51.0a2
> Build ID 	20160929004005
> User Agent 	Mozilla/5.0 (X11; Linux i686; rv:51.0) Gecko/20100101
> Firefox/51.0
> "ni" me if additional info or testing is needed

No-one mentioned ctrl+f3 before you, so no...
And ctrl+f2 is most definitely not working with e10s on. Not with any version of FF or flashgot. The addon was just never updated to handle interaction with content.

Comment 17

[Michelle Funches - QA]

e10s Enabled & Shim interposition is False then  
FlashGot items will not appear in Context Menu
Toolbar icon appears but does not function - can not download
Version 	51.0a2
Build ID 	20161004004006
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

Comment 18

[Giorgio Maone [:ma1]]

(In reply to avada from comment #16
>  The addon was just never updated to handle
> interaction with content.

In fact, I'm working around the clock to release FlashGot 1.6 and NoScript 2.9.5, which address these issues by getting rid of both shims and CPOWs in the legacy XUL branches (realistic ETA about 2 weeks), while the WebExtensions migration is in progress.

Comment 19

[avada]

(In reply to Giorgio Maone [:mao] from comment #18)
> 
> In fact, I'm working around the clock to release FlashGot 1.6 and NoScript
> 2.9.5, which address these issues by getting rid of both shims and CPOWs in
> the legacy XUL branches (realistic ETA about 2 weeks), while the
> WebExtensions migration is in progress.

Great news. Thanks for the effort. Looking forward to it.

Comment 20

[madd.korben]

Any news about 1.6? 
Can't live without FlashGot.

Thank you for your great extension and everything you create.

Comment 21

[:shell escalante]

Giorgio is working hard to port No Script fully to webextension APIs.  He's found some bugs for us in that process, that are nearly resolved.  After No Script, next to migrate is Flashgot.  Every attempt is being made to have a version of Flashgot for 57 Release, but it may come a bit after.  

As soon as Flashgot has a webextension version, when the add-on updates it will be re-enabled for the users.  

If there isn't a webextension version by Firefox 57 Release, it is possible that a temporary alternative(s) will be suggested so users have an answer if they need that capability before the update.

Comment 22

[Firefox Bug Husbandry Bot]

With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.