Closed
Bug 1161619
Opened 9 years ago
Closed 9 years ago
|RunStatsQuery| leaks |queries|
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: erahm, Assigned: pkerr)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1296139][MemShrink:P3])
Attachments
(1 file)
1.71 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
Coverity indicates that |RunStatsQuery| leaks |queries| [1] on various failure paths [2,3,4]. [1] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp#l401 [2] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp#l411 [3] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp#l418 [4] https://hg.mozilla.org/mozilla-central/annotate/754579ec0e68/media/webrtc/signaling/src/peerconnection/WebrtcGlobalInformation.cpp#l420
Comment 1•9 years ago
|
||
Missing nsAutoPtr it looks like.
Assignee | ||
Comment 2•9 years ago
|
||
The WebrtcGlobalChild should not be deleted at the end of this sequence of work. It exists until the content process containing the associated PeerConnectionCtx instance is deleted. May need to be ref counted.
Comment 3•9 years ago
|
||
The leak is RTCStatsQueries, is it not?
Assignee | ||
Comment 4•9 years ago
|
||
Yes, you are correct. I was focusing on line 401 and the function args. Now I see how the highlighted lines are the exit points.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [CID 1296139] → [CID 1296139][MemShrink:P3]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → pkerr
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8602262 -
Flags: review?(jib)
Updated•9 years ago
|
Attachment #8602262 -
Flags: review?(jib) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1d38f4141af
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•