Intermittent testReaderView | testReaderView.js - == Article title - See following stack:

RESOLVED FIXED in Firefox 40

Status

()

Firefox for Android
Reader View
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: KWierso, Assigned: Margaret)

Tracking

({intermittent-failure})

Trunk
Firefox 41
Unspecified
Android
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 unaffected, firefox40 fixed, firefox41 fixed, firefox-esr31 unaffected, firefox-esr38 unaffected)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
10:45:44 INFO - TEST-START | testReaderView
10:45:44 INFO - TEST-PASS | testReaderView | Robocop tests need the test device screen to be powered on. -
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"type":"Gecko:Ready"} - Gecko:Ready should equal Gecko:Ready
10:45:44 INFO - EventExpecter: no longer listening for Gecko:Ready
10:45:44 INFO - Registered listener for Robocop:JS
10:45:44 INFO - Loading JavaScript test from http://mochi.test:8888/tests/robocop/robocop_javascript.html?slug=1430846522531&path=testReaderView.js
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | (xpcshell\/head.js) | test 1 pending\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - (xpcshell/head.js) | test 1 pending
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | (xpcshell\/head.js) | test 2 pending\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - (xpcshell/head.js) | test 2 pending
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | testReaderView.js | Starting test_reader_view_visibility","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | Starting test_reader_view_visibility
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | testReaderView.js | Now waiting for load event from browser\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | Now waiting for load event from browser
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | (xpcshell\/head.js) | test 2 finished\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - (xpcshell/head.js) | test 2 finished
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | testReaderView.js | Received event load from browser\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | Received event load from browser
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | testReaderView.js | Condition didn't pass. Moving on.\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | Condition didn't pass. Moving on.
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-UNEXPECTED-FAIL | testReaderView.js | == Article title - See following stack:\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 WARNING - TEST-UNEXPECTED-FAIL | testReaderView | testReaderView.js - == Article title - See following stack:
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: robocop_head.js :: do_throw :: line 471\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: robocop_head.js :: do_throw :: line 471
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: robocop_head.js :: do_report_result :: line 573\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: robocop_head.js :: do_report_result :: line 573
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: robocop_head.js :: _do_check_eq :: line 583\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: robocop_head.js :: _do_check_eq :: line 583
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: robocop_head.js :: do_check_eq :: line 590\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: robocop_head.js :: do_check_eq :: line 590
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: testReaderView.js :: test_reader_view_visibility :: line 64\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: testReaderView.js :: test_reader_view_visibility :: line 64
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: self-hosted :: next :: line 624\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: self-hosted :: next :: line 624
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"JS frame :: resource:\/\/gre\/modules\/Task.jsm :: TaskImpl_run :: line 314\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 314
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - testReaderView.js | native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
10:45:44 INFO - TEST-PASS | testReaderView | Given message occurred for registered event: {"message":"\nTEST-INFO | (xpcshell\/head.js) | exiting test\n","innerType":"progress","type":"Robocop:JS"} - Robocop:JS should equal Robocop:JS
10:45:44 INFO - (xpcshell/head.js) | exiting test
10:45:44 INFO - EventExpecter: no longer listening for Robocop:JS
10:45:44 INFO - Unregistered listener for Robocop:JS
10:45:44 INFO - TEST-OK | testReaderView | took 114967ms
10:45:44 INFO - TEST-START | Shutdown
Comment hidden (Treeherder Robot)
(Assignee)

Comment 2

3 years ago
I suspect this happens if we're just slow to load the about:reader content, which is why we try to wait before doing this check:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/tests/browser/robocop/testReaderView.js#61

A real fix here would be to emit a notification from AboutReader.jsm that's only used for testing to know that we should move on.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

3 years ago
Assignee: nobody → margaret.leibovic
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

3 years ago
Blocks: 1140454
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 15

3 years ago
Created attachment 8604378 [details] [diff] [review]
Listen for AboutReader:Ready notification instead of waiting for content to appear in testReaderView

Passed locally. Here's the try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c372f253632
Attachment #8604378 - Flags: review?(mark.finkle)
Attachment #8604378 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

3 years ago
Blocks: 1158885
(Assignee)

Comment 17

3 years ago
Comment on attachment 8604378 [details] [diff] [review]
Listen for AboutReader:Ready notification instead of waiting for content to appear in testReaderView

Approval Request Comment
[Feature/regressing bug #]: bug 1158885
[User impact if declined]: intermittent oranges on Fx40 trees
[Describe test coverage new/current, TreeHerder]: green try run
[Risks and why]: low-risk, only modifies test logic
[String/UUID change made/needed]: none
Attachment #8604378 - Flags: approval-mozilla-aurora?
Comment hidden (Treeherder Robot)
(Reporter)

Comment 19

3 years ago
https://hg.mozilla.org/mozilla-central/rev/b0c2e8f10b40
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8604378 [details] [diff] [review]
Listen for AboutReader:Ready notification instead of waiting for content to appear in testReaderView

Let's fix d'em oranges! Aurora+
Attachment #8604378 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Comment 21

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/2bef28fc7f9e
status-firefox40: affected → fixed
status-firefox39: --- → unaffected
status-firefox-esr31: --- → unaffected
status-firefox-esr38: --- → unaffected
Comment hidden (Treeherder Robot)
You need to log in before you can comment on or make changes to this bug.