Closed Bug 116192 Opened 24 years ago Closed 24 years ago

nsZipArchive allocations

Categories

(Core :: General, defect, P2)

x86
Windows 2000
defect

Tracking

()

RESOLVED DUPLICATE of bug 116191
mozilla0.9.8

People

(Reporter: dp, Assigned: dp)

Details

(Keywords: perf)

We read about 200 files from jars. ReadInit happens once for each of those. ReadInit: 200 x 16 : 3,200 bytes nZipRead() owned by nsJARInputStream We could make this a member of nsJARInputStream as opposed to ptr And this allocation would go away. 200 x <filesize> : 700k This entire buffer gets thrown away once necko chops this into 4k buffers and fires OnDataAvailable(). Maybe we can pass this buffer out as a whole to OnDataAvailable() and prevent all the chopping and churning.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.8
Keywords: perf
Must have clicked the submit button one too many times...Now that would be a bug in itself right ? *** This bug has been marked as a duplicate of 116191 ***
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
dp, there's a bug on file, alexandru has a patch I believe, on Mozilla failing to disable the submit button once pressed. Of course, there's the other problem that bugzilla may do something twice that you asked for twice, because you got impatient and hit stop after the submit got thru to the server, but before the response made it thru layout. I've seen that happen, too. There are cookie-based ways for the server to suppress such dups, however. Cc'ing myk in case we don't use such, but could, in bugzilla. /be
Component: XP Miscellany → General
QA Contact: brendan → general
You need to log in before you can comment on or make changes to this bug.