1161950 - Remove support for createEvent("CloseEvent") / initCloseEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Test: http://w3c-test.org/websockets/interfaces/CloseEvent/historical.html

Comment 1

[Andrea Marchesini [:baku]]

Attachment: closeEvent.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

blink supports createEvent("CloseEvent"), but doesn't seem to have
initCloseEvent. Bizarre.


Also IE supports createEvent("CloseEvent"). It seems to have also initCloseEvent
So, no, I don't think I'm ready for this change. Could easily break something.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Anne, any opinion on this. The spec doesn't follow any implementation, and it is not quite clear to me why. 

But maybe we could try to remove createEvent("CloseEvent"); very early next cycle.

Comment 4

[Anne (:annevk)]

Well the main reason is that we don't want new createEvent() arguments or new init*Event() methods. They're entirely redundant with the constructors we introduced some time ago. I suppose we can add those we cannot remove, but I'd rather stick to the small list we have in the specifications today.

We might want to have some preventive checks in the IDL generator to ensure nobody adds new nonsense?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

Ok, let's try to remove early next cycle.

Comment 6

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc5dd3099b46

Comment 7

[Andrea Marchesini [:baku]]

Attachment: fix.patch

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef806bb00e1f

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc5dd3099b46
https://hg.mozilla.org/mozilla-central/rev/ef806bb00e1f

Comment 10

[Jean-Yves Perrier [:teoli]]

Updated docs:
https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent/initCloseEvent
https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent
and
https://developer.mozilla.org/en-US/Firefox/Releases/41#Events