Remove support for createEvent("CloseEvent") / initCloseEvent

RESOLVED FIXED in Firefox 41

Status

()

defect
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: Ms2ger, Assigned: baku)

Tracking

({dev-doc-complete, site-compat})

Trunk
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 affected, firefox41 fixed)

Details

Attachments

(2 attachments)

Assignee

Updated

4 years ago
Assignee: nobody → amarchesini
Assignee

Comment 1

4 years ago
Attachment #8602781 - Flags: review?(bugs)
Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

blink supports createEvent("CloseEvent"), but doesn't seem to have
initCloseEvent. Bizarre.


Also IE supports createEvent("CloseEvent"). It seems to have also initCloseEvent
So, no, I don't think I'm ready for this change. Could easily break something.
Attachment #8602781 - Flags: review?(bugs) → review-
Anne, any opinion on this. The spec doesn't follow any implementation, and it is not quite clear to me why. 

But maybe we could try to remove createEvent("CloseEvent"); very early next cycle.
Flags: needinfo?(annevk)

Comment 4

4 years ago
Well the main reason is that we don't want new createEvent() arguments or new init*Event() methods. They're entirely redundant with the constructors we introduced some time ago. I suppose we can add those we cannot remove, but I'd rather stick to the small list we have in the specifications today.

We might want to have some preventive checks in the IDL generator to ensure nobody adds new nonsense?
Flags: needinfo?(annevk)
Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

Ok, let's try to remove early next cycle.
Attachment #8602781 - Flags: review- → review+
Assignee

Updated

4 years ago
Keywords: checkin-needed
Assignee

Comment 7

4 years ago
Posted patch fix.patchSplinter Review
Attachment #8605806 - Flags: review?(Ms2ger)
Reporter

Updated

4 years ago
Attachment #8605806 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/dc5dd3099b46
https://hg.mozilla.org/mozilla-central/rev/ef806bb00e1f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.