Closed Bug 1161950 Opened 6 years ago Closed 6 years ago

Remove support for createEvent("CloseEvent") / initCloseEvent

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: Ms2ger, Assigned: baku)

References

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

Assignee: nobody → amarchesini
Attached patch closeEvent.patchSplinter Review
Attachment #8602781 - Flags: review?(bugs)
Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

blink supports createEvent("CloseEvent"), but doesn't seem to have
initCloseEvent. Bizarre.


Also IE supports createEvent("CloseEvent"). It seems to have also initCloseEvent
So, no, I don't think I'm ready for this change. Could easily break something.
Attachment #8602781 - Flags: review?(bugs) → review-
Anne, any opinion on this. The spec doesn't follow any implementation, and it is not quite clear to me why. 

But maybe we could try to remove createEvent("CloseEvent"); very early next cycle.
Flags: needinfo?(annevk)
Well the main reason is that we don't want new createEvent() arguments or new init*Event() methods. They're entirely redundant with the constructors we introduced some time ago. I suppose we can add those we cannot remove, but I'd rather stick to the small list we have in the specifications today.

We might want to have some preventive checks in the IDL generator to ensure nobody adds new nonsense?
Flags: needinfo?(annevk)
Comment on attachment 8602781 [details] [diff] [review]
closeEvent.patch

Ok, let's try to remove early next cycle.
Attachment #8602781 - Flags: review- → review+
Keywords: checkin-needed
Attached patch fix.patchSplinter Review
Attachment #8605806 - Flags: review?(Ms2ger)
Attachment #8605806 - Flags: review?(Ms2ger) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.