Closed Bug 1161981 Opened 5 years ago Closed 5 years ago

Error: received unexpected message 'SessionStore:crashedTabRevived' from a browser that has no tab

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
firefox40 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

Details

Attachments

(1 file)

Now that "crashedTabRevived" messages are sent via sendAsyncMessage() from the unload handler we receive those as well when removing a tab with about:tabcrashed loaded. We currently don't expect these messages from a <browser> that lots its <tab> but we should.
Iteration: --- → 40.3 - 11 May
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Attachment #8602039 - Flags: review?(wmccloskey) → review+
Any chance of a test for this?
(In reply to Bill McCloskey (:billm) from comment #2)
> Any chance of a test for this?

This didn't really break anything, the only thing we could add is a test that removes a tab, waits for the final message and then checks that we didn't log any console messages in between. That doesn't feel like we would be testing the issue itself, what do you think?
Flags: needinfo?(wmccloskey)
https://hg.mozilla.org/mozilla-central/rev/182674a08067
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Sure, seems fine not to test.
Flags: needinfo?(wmccloskey)
You need to log in before you can comment on or make changes to this bug.