1161983 - History navigation broken when using modal view

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Ed Morley [:emorley]]

This happens in many workflows, but the easiest to demonstrate is:
1) With modal view enabled, visit any show_bug.cgi page
2) Press "add an attachment"
3) Press the browser back button

Expected:
Tab returns to the show_bug.cgi page you were on

Actual:
If there was no history prior to the page at step #1 (eg you'd opened a brand new tab), then the back button is greyed out. If there was history prior to that, then pressing back at step #3 takes you to the page before #1, not the show_bug.cgi page.

Similarly, the following workflow is broken:
1) With modal view enabled visit a show_bug.cgi page
2) Submit a bug comment on that page
3) Follow a link on that bug to another bug (eg a bug listed in the "blocks" list)
4) Press the back button to try and remember what you wrote in the comment in step #2

Expected:
The back button returns you to the show_bug.cgi page with the new comment visible

Actual:
The resultant page has no new comment added, until you press refresh. Presume it's jumped back two states in the history.

Comment 1

[:glob ✱]

i suspect i have a stray 'window.location.replace'

Comment 2

[:glob ✱]

i've fixed the first issue but i'm unable to reproduce the second.

ed, do you have alternative steps to reproduce that issue?  (might be easier to ping me on irc to figure this one out).

Comment 3

[Ed Morley [:emorley]]

I'll see if I can narrow the steps down :-)

Comment 4

[:glob ✱]

from irc:

<emorley> I can't repro the second either, let's just wait until I hit it again, I'll try and pay more attention next time. Happy to call that bug fixed with just the first issue fixed

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   d911608..239c60d  master -> master