1161994 - Plugin hang UI hardcodes 8pt alert dialog text and a font, both of which may be different from the system's message-box default font and font size

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[Alice0775 White]

Attachment: screenshot

See attached

Comment 1

[Aidin Gharibnavaz]

The bug interests me, and I investigate it a little.

Dialogs in the screen shot comes from two different places.

1. The "Unresponsive Script" dialog is shown when "confirmEx" of "nsIPromptService" is called. This interface is implemented in "toolkit/components/prompts/src/nsPrompter.js" (for desktop).

2. The "Unresponsive Plugin" dialog is implemented in "dom/plugins/ipc/hangui/". And in the "HangUIDlg.rc", the font is defined in size eight. And it was like that from the first revision.

So, should we increase the font size of the "Unresponsive Plugin" dialog? Or, should we change it to use the "Prompt Services" instead of creating a window directly? (If possible?)

Comment 2

[Justin Dolske [:Dolske]]

My understanding is that the plugin prompt is native code because there can be synchronous messages being passed between Gecko and the plugin process, and we can't ensure that Gecko can safely run code in the middle of that.

> So, should we increase the font size of the "Unresponsive Plugin" dialog?
> Or, should we change it to use the "Prompt Services" instead of creating a
> window directly? (If possible?)

Which one matches the size of dialogs in other apps?

I'd sorta guess http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/hangui/HangUIDlg.rc#18 is at fault, since it's explicitly setting an 8pt font, and the Gecko UI _should_ be pulling from the system's defaults.

Although the screenshot looks off for the Unresponsive Script prompt, the font looks vertically stretched. Would be interesting to see if others can reproduce any of this with defaults OS and browser settings.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

As the original author of that code, I'm fine with mentoring this.

(In reply to Justin Dolske [:Dolske] from comment #2)
> My understanding is that the plugin prompt is native code because there can
> be synchronous messages being passed between Gecko and the plugin process,
> and we can't ensure that Gecko can safely run code in the middle of that.

Indeed.

> I'd sorta guess
> http://mxr.mozilla.org/mozilla-central/source/dom/plugins/ipc/hangui/
> HangUIDlg.rc#18 is at fault, since it's explicitly setting an 8pt font, and
> the Gecko UI _should_ be pulling from the system's defaults.

That's where this is coming from, yes. From what I can see, we should be replacing the DS_SETFONT style with the DS_SHELLFONT style. From what I've read on MSDN, Windows should then use the correct system font. The rest of that dialog template looks like it is set up to handle that.

If it still looks off, we can investigate further changes. We already do some work during initialization to resize the buttons for localized text.

Comment 4

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.