1162022 - Autophone - --close-when-done --autorun no longer supported in testing/mochitest/runtests.py

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

bug 1155338 removed --close-when-done --autorun from testing/mochitest/runtests.py which broke the mochitest unit tests in Autophone.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: PR 30

Comment 2

[Andrew Halberstadt [:ahal]]

Ah, sorry about that. --autorun and --close-when-done are the default behaviours now, so it should be safe to just remove those command lines from wherever they are defined.

Also --console-level now defaults to INFO so you can remove that too if you want.

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1442210
repository: mozilla-central
start_time: 2015-05-06T04:40:47
who: bclary[at]mozilla[dot]com
machine: nexus-7-jss15q-2
buildname: android-4-3-armv7-api11 mozilla-central opt test Autophone Mochitest Media-Mm
revision: 60349cbc3d4e

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1442209
repository: mozilla-central
start_time: 2015-05-06T05:29:56
who: bclary[at]mozilla[dot]com
machine: nexus-4-jdq39-3
buildname: android-4-2-armv7-api11 mozilla-central opt test Autophone Mochitest Media-Mm
revision: 60349cbc3d4e

Comment 5

[Bob Clary [:bc] (inactive)]

Am also going to need

-                '--robocop=%s' % self.parms['test_manifest'],
+                '--robocop_ini=%s' % self.parms['test_manifest'],

still testing atm.

Comment 6

[Bob Clary [:bc] (inactive)]

Comment on attachment 8602097 [details] [review]
PR 30

Fixed the changed --robocop-ini option.

Comment 7

[Geoff Brown [:gbrown]]

Comment on attachment 8602097 [details] [review]
PR 30

That looks right.

Comment 8

[Bob Clary [:bc] (inactive)]

Thanks! https://github.com/mozilla/autophone/commit/24f288cd3d1b53553411e6bbc03294b31a154c1a