1162027 - [Messages][New Gaia Architecture] extract inbox/index.html

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1162027-split-inbox-index > mozilla-b2g:master

Comment 2

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8606970 [details] [review]
[gaia] azasypkin:bug-1162027-split-inbox-index > mozilla-b2g:master

Hey Steve,

In this patch I've extracted views/inbox/index.html from main index.html + removed some more ConversationView-InboxView dependencies.

You can test inbox index.html in browser (fixed some desktop mocks as well). inbox/index.html loads only files needed for inbox, so it's not possible to navigate to another view since new view should be hosted in a separate iframe with its own dependencies loaded. Navigation will be possible once we start using little-browser.

Currently I use main startup.js, but still poking around to see if I can come up with something smarter.

Thanks!

Comment 3

[Steve Chung [:steveck]]

Comment on attachment 8606970 [details] [review]
[gaia] azasypkin:bug-1162027-split-inbox-index > mozilla-b2g:master

I think this separation is good with dependencies clean up by draft change event driven. And thanks for the addional clean up in oter place!

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8606970 [details] [review]
[gaia] azasypkin:bug-1162027-split-inbox-index > mozilla-b2g:master

Hey Steve,

Thanks for the feedback! I've updated PR according to your good idea about "InboxView.showDraftSavedBanner" with slight modification to get rid of this dependency from ConversationView entirely.

What do you think?

Thanks!

Comment 5

[Steve Chung [:steveck]]

Mostly looks good and I like the way to make the saveDraft simpler with less inbox view access. I only one concern about the thread deletion in inbox view and it might cause duplicate update/removal action(but it won't lead the incorrect result). Some thoughts left on github.

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #5)
> Mostly looks good and I like the way to make the saveDraft simpler with less
> inbox view access. I only one concern about the thread deletion in inbox
> view and it might cause duplicate update/removal action(but it won't lead
> the incorrect result). Some thoughts left on github.

Hey Steve,

I've proposed possible solution at Github, please let me know what you think.

Thanks!

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 8606970 [details] [review]
[gaia] azasypkin:bug-1162027-split-inbox-index > mozilla-b2g:master

Yeah, I think this check should be enough for now, thanks for all the efforts!

Comment 8

[Oleg Zasypkin [:azasypkin]]

Thanks for review!

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ee2f5b57b8aaf1ad07c9fde61ced7358aac78670