1162032 - Turn off the mozilla-b2g30_v1_4 branch and JB Flame device image builds in automation

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Per email w/ Kai-Zhen:
> I got the answer from PM, there are still devices with 1.4 are on market,
> it would be better we keep maintain this branch. And we can stop the
> build on this branch. IMO, I think we should disable all nightly builds
> and tests. I am thinking if we need to keep the build for push?
> How do you think?

While I'd love to kill this branch entirely, nightlies would be a start anyway.

I'm continuing the email thread because the rationale given there for keeping other builds alive doesn't seem to fit with the reasons we've given for killing other branches (i.e. 1.3t was turned off while devices were still on the market AFAIK). It seems to me that the more-relevant questions are:

1) Are we expecting partners with 1.4-based phones on the market to ship 1.4-based updates to those phones to pick up fixes that have landed since?
2) Are there new 1.4-based phones still coming to market or have they moved on to newer releases?

Unless the answer is yes to either of those, I don't see what we're gaining by keeping support for b2g30 around. It's our oldest-supported Gecko version right now and backporting security fixes is becoming increasingly difficult. It's a waste of engineering time spending non-trivial effort backporting and testing fixes that nobody's ever actually going to see on their phone.

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Ryan, I agree with you.

Steven, Vance, How do you think?

Comment 2

[Steven Yang [:styang]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0)
> Per email w/ Kai-Zhen:
> > I got the answer from PM, there are still devices with 1.4 are on market,
> > it would be better we keep maintain this branch. And we can stop the
> > build on this branch. IMO, I think we should disable all nightly builds
> > and tests. I am thinking if we need to keep the build for push?
> > How do you think?
> 
> While I'd love to kill this branch entirely, nightlies would be a start
> anyway.
> 
> I'm continuing the email thread because the rationale given there for
> keeping other builds alive doesn't seem to fit with the reasons we've given
> for killing other branches (i.e. 1.3t was turned off while devices were
> still on the market AFAIK). It seems to me that the more-relevant questions
> are:
> 
> 1) Are we expecting partners with 1.4-based phones on the market to ship
> 1.4-based updates to those phones to pick up fixes that have landed since?
  No
> 2) Are there new 1.4-based phones still coming to market or have they moved
> on to newer releases?
  AFAIK, move on to newer release such as 2.0, 2.1. or even 2.2...
> 
> Unless the answer is yes to either of those, I don't see what we're gaining
> by keeping support for b2g30 around. It's our oldest-supported Gecko version
> right now and backporting security fixes is becoming increasingly difficult.
> It's a waste of engineering time spending non-trivial effort backporting and
> testing fixes that nobody's ever actually going to see on their phone.
Agree. I have no question to stop the nightly builds for 1.4 (aka. b2g30)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

(In reply to Steven Yang [:styang] from comment #2)
> Agree. I have no question to stop the nightly builds for 1.4 (aka. b2g30)

I think there was already agreement about turning off nightlies. The question is whether we can turn off *all* builds/tests on b2g30 rather than just a very small subset. From the answers you gave, it sounds like we can.

Comment 4

[Steven Yang [:styang]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #3)
> (In reply to Steven Yang [:styang] from comment #2)
> > Agree. I have no question to stop the nightly builds for 1.4 (aka. b2g30)
> 
> I think there was already agreement about turning off nightlies. The
> question is whether we can turn off *all* builds/tests on b2g30 rather than
> just a very small subset. From the answers you gave, it sounds like we can.

Yes, that's what I mean. We can turn off *all* builds/tests. Thanks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Thanks for confirming!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove b2g30 from buildbotcustom

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove b2g30 from tools

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Bonus, this means we can kill the Flame JB builds now too.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove b2g30 from buildbot-configs

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Going to finish the b2g30 patches, then will post JB Flame removal patches as well.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove b2g30 from braindump

AFAICT, this file doesn't have much use anymore, so I went ahead and removed it. I'm open to keeping it and making more useful changes to it otherwise.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove b2g30 from mozharness

The versioned B2G release branches are on their own mozharness branches. Am I going to need to cherry-pick this patch and the forthcoming Flame patch to them as well?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove flame from tools

Not quite sure about the change to the flame-kk line in platforms.py

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove flame from buildbot-configs

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove flame from braindump

buildfaster_report.py is a mess in general with respect to the list of builds it contains, but oh well.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Attachment: remove flame from mozharness

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Note to self, we should also close the mozilla-b2g30 branch on mozharness. And will need to file a BMO bug for disabling the various 1.4 approval & tracking flags.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

I've closed b2g30 in Treestatus with the intent to remove is fully once these patches are in production. I've also updated the B2G Landing wiki to reflect the EOL status.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604718 [details] [diff] [review]
remove b2g30 from buildbot-configs

https://hg.mozilla.org/build/buildbot-configs/rev/d398c70a79c3

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604764 [details] [diff] [review]
remove flame from buildbot-configs

https://hg.mozilla.org/build/buildbot-configs/rev/eb4477c3669f

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604751 [details] [diff] [review]
remove b2g30 from braindump

https://hg.mozilla.org/build/braindump/rev/f81a5eb71751

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604765 [details] [diff] [review]
remove flame from braindump

https://hg.mozilla.org/build/braindump/rev/5b3f554367b0

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604655 [details] [diff] [review]
remove b2g30 from buildbotcustom

https://hg.mozilla.org/build/buildbotcustom/rev/99b03dfbc0c1

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604662 [details] [diff] [review]
remove b2g30 from tools

https://hg.mozilla.org/build/tools/rev/26cff23e4b57

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604763 [details] [diff] [review]
remove flame from tools

https://hg.mozilla.org/build/tools/rev/d4bb56e2c542

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604758 [details] [diff] [review]
remove b2g30 from mozharness

https://hg.mozilla.org/build/mozharness/rev/608ee303f9b5

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8604766 [details] [diff] [review]
remove flame from mozharness

https://hg.mozilla.org/build/mozharness/rev/c5fbe5b9de2c

Comment 28

[Ryan VanderMeulen [:RyanVM]]

And closing the mozilla-b2g30_v1_4 mozharness branch:
https://hg.mozilla.org/build/mozharness/rev/85d46afaed11

Comment 29

[Rail Aliiev [:rail]]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/d398c70a79c3

Comment 30

[Rail Aliiev [:rail]]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/eb4477c3669f

Comment 31

[Rail Aliiev [:rail]]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/99b03dfbc0c1

Comment 32

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/1a2600cf03fc

Comment 33

[Rail Aliiev [:rail]]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/1a2600cf03fc

Comment 34

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17)
> And will need to file a BMO bug for disabling the various 1.4 approval &
> tracking flags.

Bug 1165357.

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #18)
> I've closed b2g30 in Treestatus with the intent to remove is fully once
> these patches are in production.

Removed.

Remaining cleanups can be tracked in their own bugs. Closing this out.