1162180 - [accessibility][gaia-switch] Make sure gaia-switch is accessible to screen reader.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Ensure labeling works well with the switch
Ensure switch has all necessary semantics of a switch/checkbox
Ensure checked/unchecked state is announced.

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

Could you help verify if the switch button has expected behavior in Screen Reader?

(local test result: Screen Reader speak switch button as `check` button and speak the checked/unchecked/unavailable state)

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Fred Lin [:gasolin] from comment #1)
> Created attachment 8605653 [details] [review]
> pull request redirect to github
> 
> Could you help verify if the switch button has expected behavior in Screen
> Reader?
> 
> (local test result: Screen Reader speak switch button as `check` button and
> speak the checked/unchecked/unavailable state)

Hi Fred, thanks for looking into this. I just realized we already support proposed specification for ARIA switch role (see http://rawgit.com/w3c/aria/master/aria/aria.html#switch). It is essentially a subclass of a checkbox role and uses aria-checked in a similar fashion. 

The PR itself is missing actual role semantics on the gaia-switch element. I think what you want is to add role="switch" attribute to it so it is accessible to the screen reader as it isn't right now.

Comment 3

[[e-mail]]

Thanks for feedback. I try to use `role=swich` but the FxOS ScreenReader does not respond for that element. 

Switch back to `role=checkbox` works well.

Comment 4

[[e-mail]]

@Marco I found you on phonebook, do you know if Screen Reader support the `role=swich` on FxOS?

Comment 5

[Marco Zehe (:MarcoZ)]

Hi Fred,

If it doesn't, it's a bug and should be fixed. :) But fortunately, we have control over it in the accessible/AccessFu folder in Gecko.

Yura, want to implement support for the role and add tests so this can be used in FX OS?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Marco Zehe (:MarcoZ) from comment #5)
> Hi Fred,
> 
> If it doesn't, it's a bug and should be fixed. :) But fortunately, we have
> control over it in the accessible/AccessFu folder in Gecko.
> 
> Yura, want to implement support for the role and add tests so this can be
> used in FX OS?

Yes we should be able to add it shortly. Will make a bug for that

Comment 7

[Wilson Page [:wilsonpage]]

Comment on attachment 8605653 [details] [review]
pull request redirect to github

LANDED https://github.com/gaia-components/gaia-switch/commit/c28980752749d6787a812a6368689cee3c7e55cf

Comment 8

[Wilson Page [:wilsonpage]]

Please close this bug if attachment 8605653 [details] [review] was the only dependency.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Wilson Page [:wilsonpage] from comment #8)
> Please close this bug if attachment 8605653 [details] [review] was the only
> dependency.

Ill test it around and will if all's good

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: gh-pages update with PR #8 included

Comment 12

[Wilson Page [:wilsonpage]]

Comment on attachment 8614169 [details] [review]
gh-pages update with PR #8 included

This doesn't require review, please just push to gh-pages frequently. If this could be automated, even better :)

Comment 13

[Wilson Page [:wilsonpage]]

Comment on attachment 8614131 [details] [review]
Github pull request.

LANDED https://github.com/gaia-components/gaia-switch/commit/a4af52c07cdb15a5988d50bf0deca7257d1f3a51

Comment 14

[Wilson Page [:wilsonpage]]

STAMPED https://github.com/gaia-components/gaia-switch/releases/tag/v0.2.1

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Wilson Page [:wilsonpage] from comment #12)
> Comment on attachment 8614169 [details] [review]
> gh-pages update with PR #8 included
> 
> This doesn't require review, please just push to gh-pages frequently. If
> this could be automated, even better :)

Hi Wilson, I don't have the perms for pushing to gaia-components, would you be able to push for me in this case?

Comment 16

[Wilson Page [:wilsonpage]]

(In reply to Yura Zenevich [:yzen] from comment #15)
> (In reply to Wilson Page [:wilsonpage] from comment #12)
> > Comment on attachment 8614169 [details] [review]
> > gh-pages update with PR #8 included
> > 
> > This doesn't require review, please just push to gh-pages frequently. If
> > this could be automated, even better :)
> 
> Hi Wilson, I don't have the perms for pushing to gaia-components, would you
> be able to push for me in this case?

Done. And added you as 'owner' to give you push rights.

Comment 17

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: npm3 integration tests.

Comment 18

[Wilson Page [:wilsonpage]]

Comment on attachment 8695447 [details] [review]
npm3 integration tests.

https://github.com/fxos-components/gaia-switch/commit/076f44da6c60349f1c820fe60bf90bd0a74341fa