Closed Bug 1162198 Opened 4 years ago Closed 4 years ago

[EME] Doorhanger that notifies user of DRM usage should include a Learn More link

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox38 --- fixed
firefox38.0.5 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
The doorhanger that notifies the user when DRM is being used should contain a "Learn More" link. The current experience is that the doorhanger says "Some audio or video on this site uses DRM software, which may limit what Firefox can let you do with it.", with a "Configure…" button that takes you to the Preferences page, which has a checkbox to enable/disable DRM and a Learn More link. But the doorhanger itself does not have a Learn More link.

The original UX specs included this. Looks like we just overlooked it when implementing bug 1111148, and it wasn't caught until just now. :-(

The fix is trivial.
Comment on attachment 8602259 [details] [diff] [review]
Patch v.1

I like how our codebase has different capitalization versions of this property, because... yeah!
Attachment #8602259 - Flags: review+
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8602259 [details] [diff] [review]
Patch v.1

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: Missing "Learn More" link (See release-drivers discussion)
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: basically zero, the URL is already used elsewhere, and we're just using a standard PopupNotifications API to add the link to the panel (other panels already do this with their own links).
[String/UUID change made/needed]: There are NO string changes.
Attachment #8602259 - Flags: approval-mozilla-beta?
Attachment #8602259 - Flags: approval-mozilla-aurora?
Comment on attachment 8602259 [details] [diff] [review]
Patch v.1

s/beta/release/, again, since this should at least be included in 38.0.5.
Attachment #8602259 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Comment on attachment 8602259 [details] [diff] [review]
Patch v.1

Sure, let's take it for 38.0.5.
Attachment #8602259 - Flags: approval-mozilla-release?
Attachment #8602259 - Flags: approval-mozilla-release+
Attachment #8602259 - Flags: approval-mozilla-aurora?
Attachment #8602259 - Flags: approval-mozilla-aurora+
Assignee: nobody → dolske
We are going to make a second build of 38, so, let's take it in the 38.0 relbranch release ( GECKO380_2015050320_RELBRANCH )
You need to log in before you can comment on or make changes to this bug.