Closed
Bug 1162198
Opened 9 years ago
Closed 9 years ago
[EME] Doorhanger that notifies user of DRM usage should include a Learn More link
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 40
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file)
964 bytes,
patch
|
Gijs
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
The doorhanger that notifies the user when DRM is being used should contain a "Learn More" link. The current experience is that the doorhanger says "Some audio or video on this site uses DRM software, which may limit what Firefox can let you do with it.", with a "Configure…" button that takes you to the Preferences page, which has a checkbox to enable/disable DRM and a Learn More link. But the doorhanger itself does not have a Learn More link. The original UX specs included this. Looks like we just overlooked it when implementing bug 1111148, and it wasn't caught until just now. :-( The fix is trivial.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51792c1e5fb7
Comment 2•9 years ago
|
||
Comment on attachment 8602259 [details] [diff] [review] Patch v.1 I like how our codebase has different capitalization versions of this property, because... yeah!
Attachment #8602259 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → affected
status-firefox38.0.5:
--- → affected
status-firefox39:
--- → affected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8602259 [details] [diff] [review] Patch v.1 Approval Request Comment [Feature/regressing bug #]: n/a [User impact if declined]: Missing "Learn More" link (See release-drivers discussion) [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: basically zero, the URL is already used elsewhere, and we're just using a standard PopupNotifications API to add the link to the panel (other panels already do this with their own links). [String/UUID change made/needed]: There are NO string changes.
Attachment #8602259 -
Flags: approval-mozilla-beta?
Attachment #8602259 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8602259 [details] [diff] [review] Patch v.1 s/beta/release/, again, since this should at least be included in 38.0.5.
Attachment #8602259 -
Flags: approval-mozilla-beta? → approval-mozilla-release?
Comment 6•9 years ago
|
||
Comment on attachment 8602259 [details] [diff] [review] Patch v.1 Sure, let's take it for 38.0.5.
Attachment #8602259 -
Flags: approval-mozilla-release?
Attachment #8602259 -
Flags: approval-mozilla-release+
Attachment #8602259 -
Flags: approval-mozilla-aurora?
Attachment #8602259 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Comment 9•9 years ago
|
||
We are going to make a second build of 38, so, let's take it in the 38.0 relbranch release ( GECKO380_2015050320_RELBRANCH )
Comment 10•9 years ago
|
||
Now on GECKO380_2015050320_RELBRANCH https://hg.mozilla.org/releases/mozilla-release/rev/4c4dc6640c7e
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•