1162315 - Save password prompt string overlaps button text

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: IMG_2662.PNG

Looks like the snack bar is in the incorrect place or doesn't account for the placement of the buttons underneath

Comment 1

[Stephan Leroux [:sleroux]]

Also, I found it pretty meta that I encountered a bug while trying to file a bug...

Comment 3

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/441

This is some cleanup for these constraints (I reworked them so that the buttons are always below the text/image). I also gave these a min-width on tablets here, and tweaked the colors slightly.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8603578 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/441

Works well. Left a couple a couple of comments regarding the way we're sizing the SnackBar widget.

Comment 5

[Wesley Johnston (:wesj)]

Updated this. I remember having issues if I didn't explicitly set a width originally here, but constraints seems smart enough to find a tight-wrapping height for me automatically now. I musta been missing one it needed originally. Changes are in their own commit.

Comment 6

[Stephan Leroux [:sleroux]]

Looks good - just a minor nit comment and a question

Comment 7

[Wesley Johnston (:wesj)]

Merged