Closed Bug 1162319 Opened 8 years ago Closed 8 years ago

Improve test_unprefixing_service.html (via its helper-file unprefixing_service_iframe.html)

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file, 1 obsolete file)

fix v2
11.22 KB, patch
Details | Diff | Splinter Review 
Right now, unprefixing_service_iframe.html (a helper for test_unprefixing_service.html ) assumes that unprefixed specified style (in elem.style) will always be the same as unprefixed computed style (from  getComputedStyle).

This isn't true, because we serialize differently for these two cases. (e.g. converting color names to "rgb(...)" for computed style)

Filing this bug on broadening this test slightly to support different values for specified vs. computed style, and to add a bit more sanity-checking.
Blocks: 1132748
Attached patch fix (obsolete) — — Splinter Review 
Here's the patch.
Attached patch fix v2 — — Splinter Review 
er, forgot to qref in a bit of final cleanup.
Attachment #8602424 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/3efe5f06818d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.