1162325 - Modify website model for Phase 0

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, enhancement, P1)

Description

[David Durst [:ddurst]]

The data coming (originally from e.me, sort of) to Phase 0 will have:
a. three "name/title" fields (short name, long name, display title)
b. two URLs ("desktop URL" and "mobile URL", no need to translate them)
c. an indication about the "responsiveness" of the desktop URL (Y/N/R, where R means it redirects to some mobile-specific site)

For our purposes, the combination of b. and c. will tell us which URL to link to.

Region_exclusions seems potentially confusing. Since this model will deal in regional relavance (more like inclusion than exclusion, if we must compare), maybe better to rename that?

Comment 1

[David Durst [:ddurst]]

Based on the way data is being recorded (https://bugzilla.mozilla.org/show_bug.cgi?id=1161872#c1), I wonder if we should bother with c. right now. Seems like we're not going to know if a desktopURL is responsive if they redirect, so we'd have to re-check those anyway.

Plus, we don't know what requirements desktop has for showing sites.

Comment 2

[David Durst [:ddurst]]

Yargh, just realized that the keywords intended for the sites model is pulled from the site metadata (rather than the keywords that the app model uses). That should be a translated field as well.

Comment 3

[Mathieu Pillard [:mat]]

Or we should just concatenate all keywords regardless of language ?

Comment 4

[David Durst [:ddurst]]

Depends on how relevance is scored. If it's looking for any keyword match (and not how many of the keywords match) then I'm all for it.

Comment 5

[Mathieu Pillard [:mat]]

The relevance boost should be applied (both for apps and websites) only once no matter how many keywords match.

Comment 6

[Mathieu Pillard [:mat]]

IRC discussion regarding a):

<mat> expose that as short_name, name, title
<mat> title is the title element of the website, we probably won't ever expose it to fireplace

Then in fireplace, display short_name || name in list pages, and name in detail pages.

Comment 7

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/c13b3e4015778e74d57271e11683d3d1098eebf9