1162334 - email_enabled value inverted in User.update RPC call

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Jeff Fearn]

Attachment: patch to remove mapping and invert value in DB

email_enabled should be the inverse of disable_mail, however mail_enabled is mapped directly to disable_mail and thus you have to invert the boolean value to get the expected behaviour.

e.g.

User.update({'email_enabled': 1}) should enable email, but it disables it.
User.update({'email_enabled': 0}) should disable email, but it enables it.

Attached is a patch to remove the mapping and add a sub to invert the value supplied in the DB.

Comment 1

[:glob ✱]

confirming.

Comment 2

[:glob ✱]

Comment on attachment 8602437 [details] [diff] [review]
patch to remove mapping and invert value in DB

Review of attachment 8602437 [details] [diff] [review]:
-----------------------------------------------------------------

the changes look good, but don't pass tests:

#   Failed test 'Bugzilla/User.pm POD coverage is 99%. Undocumented methods: set_email_enabled'
#   at t/011pod.t line 108.

you'll also need to update Bugzilla/API/1_0/Resource/User.pm (trunk only)

::: Bugzilla/User.pm
@@ +269,1 @@
>  sub set_extern_id    { $_[0]->set('extern_id', $_[1]); }

realign the {s please

Comment 3

[Jeff Fearn]

Attachment: fix issues noted in patch 1

Wasn't sure where to add pod so I just added it to teh bottom of the (hopefully) relevant section.

Comment 4

[:glob ✱]

Comment on attachment 8604413 [details] [diff] [review]
fix issues noted in patch 1

Review of attachment 8604413 [details] [diff] [review]:
-----------------------------------------------------------------

> Wasn't sure where to add pod so I just added it to teh bottom of the (hopefully) relevant section.
the location looks good to me.

please ensure you run tests prior to attaching a patch:

t/011pod.t ........... 76/377
#   Failed test 'Bugzilla/User.pm has incorrect POD syntax --ERROR'
#   at t/011pod.t line 80.

pointing perldoc at the file shows the issue (at the end of the output):

POD ERRORS
    Hey! The above document had some coding errors, which are explained
    below:

    Around line 3104:
        '=item' outside of any '=over'

Comment 5

[Jeff Fearn]

Attachment: Fix POD error

Comment 6

[:glob ✱]

Comment on attachment 8604478 [details] [diff] [review]
Fix POD error

Review of attachment 8604478 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 7

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   bd4bfe3..3ff9b3e  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   e191f86..3d2b724  5.0 -> 5.0

To ssh://[e-mail]/bugzilla/bugzilla.git
   3a21f12..42ae6d0  4.4 -> 4.4