Closed Bug 1162422 Opened 4 years ago Closed 4 years ago

Perma-failing marionette test, TEST-UNEXPECTED-FAIL | test_fakevolume.js | state - got -1, expected 4

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed

People

(Reporter: edgar, Assigned: kershaw)

References

Details

Attachments

(1 file, 1 obsolete file)

https://treeherder.mozilla.org/logviewer.html#?job_id=1866668&repo=b2g-inbound

17:56:35 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | state - got -1, expected 4
17:56:35 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | mount generation should be incremented - false was false, expected true
17:56:37 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | AssertionError: 2 tests failed 

It seems a regression of bug 1126694.
Hi Kershaw, could you help to take a look? Thank you.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-searchStr=mnw&exclusion_profile=false
Flags: needinfo?(kechang)
Blocks: 1081529
Blocks: 1126694
(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Hi Kershaw, could you help to take a look? Thank you.
> 
> https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-
> searchStr=mnw&exclusion_profile=false

Hi Dave,
There is a test case test_fakevolume.js expects that the initial state of a fake volume should be STATE_INIT, not STATE_MOUNTED. It seems that we should revert CreateFakeVolume back in order to let this test pass.
What do you think?
Thanks.
Assignee: nobody → kechang
Flags: needinfo?(kechang) → needinfo?(dhylands)
(In reply to Kershaw Chang [:kershaw] from comment #2)
> (In reply to Edgar Chen [:edgar][:echen] from comment #1)
> > Hi Kershaw, could you help to take a look? Thank you.
> > 
> > https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-
> > searchStr=mnw&exclusion_profile=false
> 
> Hi Dave,
> There is a test case test_fakevolume.js expects that the initial state of a
> fake volume should be STATE_INIT, not STATE_MOUNTED. It seems that we should
> revert CreateFakeVolume back in order to let this test pass.
> What do you think?
> Thanks.

I think we just fix the test.

Having the fake volumes start in STATE_INIT just feels wrong to me.

We currently don't use fake volumes in any shipping devices, so this shouldn't cause any problems.
Flags: needinfo?(dhylands)
Attached patch Fix test cases (obsolete) — Splinter Review
Hi Dave,
Could you please take a look at this patch?
I've also modified CreateFakeVolume to call SetState in order to increase the value of sMountGeneration.
Thanks.
Attachment #8604507 - Flags: review?(dhylands)
Comment on attachment 8604507 [details] [diff] [review]
Fix test cases

Review of attachment 8604507 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks
Attachment #8604507 - Flags: review?(dhylands) → review+
Carry reviewer's name.

test_fakevolume.js pass now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=675e374f3229&exclusion_profile=false
Attachment #8604507 - Attachment is obsolete: true
Attachment #8605101 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bd5d5dd4be0c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.