1162422 - Perma-failing marionette test, TEST-UNEXPECTED-FAIL | test_fakevolume.js | state - got -1, expected 4

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/logviewer.html#?job_id=1866668&repo=b2g-inbound

17:56:35 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | state - got -1, expected 4
17:56:35 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | mount generation should be incremented - false was false, expected true
17:56:37 ERROR - TEST-UNEXPECTED-FAIL | test_fakevolume.js | AssertionError: 2 tests failed 

It seems a regression of bug 1126694.

Comment 1

[Edgar Chen [:edgar]]

Hi Kershaw, could you help to take a look? Thank you.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-searchStr=mnw&exclusion_profile=false

Comment 2

[Kershaw Chang [:kershaw]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Hi Kershaw, could you help to take a look? Thank you.
> 
> https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-
> searchStr=mnw&exclusion_profile=false

Hi Dave,
There is a test case test_fakevolume.js expects that the initial state of a fake volume should be STATE_INIT, not STATE_MOUNTED. It seems that we should revert CreateFakeVolume back in order to let this test pass.
What do you think?
Thanks.

Comment 3

[Dave Hylands [:dhylands]]

(In reply to Kershaw Chang [:kershaw] from comment #2)
> (In reply to Edgar Chen [:edgar][:echen] from comment #1)
> > Hi Kershaw, could you help to take a look? Thank you.
> > 
> > https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&filter-
> > searchStr=mnw&exclusion_profile=false
> 
> Hi Dave,
> There is a test case test_fakevolume.js expects that the initial state of a
> fake volume should be STATE_INIT, not STATE_MOUNTED. It seems that we should
> revert CreateFakeVolume back in order to let this test pass.
> What do you think?
> Thanks.

I think we just fix the test.

Having the fake volumes start in STATE_INIT just feels wrong to me.

We currently don't use fake volumes in any shipping devices, so this shouldn't cause any problems.

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Fix test cases

Hi Dave,
Could you please take a look at this patch?
I've also modified CreateFakeVolume to call SetState in order to increase the value of sMountGeneration.
Thanks.

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 8604507 [details] [diff] [review]
Fix test cases

Review of attachment 8604507 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Fix test cases, r=dhylands

Carry reviewer's name.

test_fakevolume.js pass now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=675e374f3229&exclusion_profile=false

Comment 7

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/bd5d5dd4be0c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd5d5dd4be0c