Closed
Bug 1162546
Opened 10 years ago
Closed 10 years ago
Create imagecompare test that plays video from browser
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Firefox OS Graveyard
Gaia::UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: njpark, Assigned: njpark)
Details
Attachments
(1 file)
It would be useful to have a script that plays video from browser, and see whether all plays normally without any visual issues.
![]() |
Assignee | |
Updated•10 years ago
|
Assignee: nobody → npark
![]() |
||
Comment 1•10 years ago
|
||
![]() |
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8603413 [details] [review]
[gaia] npark-mozilla:1162546 > mozilla-b2g:master
changed take_screenshot() method to preserve the browser object. Otherwise it causes 'Elements have not seen before' error.
Attachment #8603413 -
Flags: review?(jlorenzo)
Attachment #8603413 -
Flags: review?(dave.hunt)
Updated•10 years ago
|
Attachment #8603413 -
Flags: review?(dave.hunt) → review-
Comment 3•10 years ago
|
||
Comment on attachment 8603413 [details] [review]
[gaia] npark-mozilla:1162546 > mozilla-b2g:master
I agree on Dave's proposal.
Attachment #8603413 -
Flags: review?(jlorenzo) → review-
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #8603413 -
Flags: review?(jlorenzo)
Attachment #8603413 -
Flags: review?(dave.hunt)
Attachment #8603413 -
Flags: review-
Comment 4•10 years ago
|
||
Comment on attachment 8603413 [details] [review]
[gaia] npark-mozilla:1162546 > mozilla-b2g:master
r=me with nit addressed.
Attachment #8603413 -
Flags: review?(dave.hunt) → review+
Updated•10 years ago
|
Attachment #8603413 -
Flags: review?(jlorenzo) → review+
![]() |
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
![]() |
||
Updated•10 years ago
|
Keywords: checkin-needed
![]() |
||
Comment 5•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a9ba093155749962703b335e1101ab3b4fd6dfb0
![]() |
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•